[ENHANCEMENT] ADD V3.4+ Email Template Approach by MaximilianoRicoTabo · Pull Request #56 · strangerstudios/pmpro-email-confirmation

MaximilianoRicoTabo · 2025-03-04T22:08:20Z

Create a new class in the hierarchy of the PMPro_Email_Template class
Require the child class if Parent class exists. Add filter to old template otherwise
Call new class if we're in the class exists

All Submissions:

Have you followed the Contributing guidelines?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Create a new class in the hierarchy of the PMPro_Email_Template class
Require the child class if Parent class exists. Add filter to old template otherwise
Call new class if we're in the class exists

How to test the changes in this Pull Request:

Look for Users or Members table list view pages and click resend confirmation link.
Test with 3.4+ and 3.4-

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

* Create a new class in the hierarchy of the PMPro_Email_Template class * Require the child class if Parent class exists. Add filter to old template otherwise * Call new class if we're in the class exists

MaximilianoRicoTabo · 2025-03-05T13:09:23Z

Made this one a draft @dparker1005 because of these doubts.

The body seems to be dynamically build in the old approach based on the body string itself ? Kind of circular reference. Not sure how do we want to deal with this.
https://github.com/strangerstudios/pmpro-email-confirmation/blob/dev/pmpro-email-confirmation.php#L431-L435
Kept commented few variables on its description because I think they should work but not need to be listed but could be wrong, let me know your thoughts please and I amend. https://github.com/strangerstudios/pmpro-email-confirmation/pull/56/files#diff-47496af6c6f425f510897247d9007df45f7e608190d83df9748651a7633ae65dR97-R99

Copilot

Pull Request Overview

This PR refactors the email confirmation system to support the new PMPro Email Template framework while maintaining backward compatibility with the legacy email system. It conditionally loads the appropriate email handling based on whether the PMPro_Email_Template class exists.

Key changes:

Introduces a new PMPro_Email_Template_Resend_Confirmation class for modern email template handling
Modifies the plugin initialization to conditionally include the new email template class or register the legacy template filter
Updates pmproec_resend_confirmation_email() to handle both new and legacy email systems with proper success message handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
pmpro-email-confirmation.php	Adds conditional logic to support both new PMPro Email Template system and legacy email system, updates plugin initialization hook priority, and improves success message handling
classes/email-templates/class-pmpro-email-template-pmpro-email-confirmation-resend-confirmation.php	New email template class extending PMPro_Email_Template for handling resend confirmation emails in the modern framework

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T13:28:35Z

+class PMPro_Email_Template_Resend_Confirmation extends PMPro_Email_Template {
+
+	/**
+	 * The parent user.


The comment 'The parent user' is unclear. This should be 'The user receiving the confirmation email' or simply 'The user' to better describe the property's purpose.

Suggested change

* The parent user.

* The user receiving the confirmation email.

Copilot · 2025-10-29T13:28:35Z

+	 *
+	 * @since TBD
+	 *
+	 * @param WP_User $user The user will receive the email.


Corrected grammar from 'The user will receive' to 'The user who will receive' for better readability.

Suggested change

* @param WP_User $user The user will receive the email.

* @param WP_User $user The user who will receive the email.

Copilot · 2025-10-29T13:28:36Z

+			// '!!display_name!!' => esc_html__( 'The display name of the user need to confirm the email', 'pmpro-email-confirmation' ),
+			// '!!user_login!!' => esc_html__( 'The login name of the user need to confirm the email', 'pmpro-email-confirmation' ),
+			// '!!user_email!!' => esc_html__( 'The email address of the user need to confirm the email', 'pmpro-email-confirmation' ),


These commented-out template variables are defined in get_email_template_variables() (lines 114-116) but not exposed in get_email_template_variables_with_description(). If these variables are not intended to be available for use in email templates, they should be removed from the method. If they should be available, uncomment and fix the grammar ('user need' should be 'user who needs').

Suggested change

// '!!display_name!!' => esc_html__( 'The display name of the user need to confirm the email', 'pmpro-email-confirmation' ),

// '!!user_login!!' => esc_html__( 'The login name of the user need to confirm the email', 'pmpro-email-confirmation' ),

// '!!user_email!!' => esc_html__( 'The email address of the user need to confirm the email', 'pmpro-email-confirmation' ),

'!!display_name!!' => esc_html__( 'The display name of the user who needs to confirm the email.', 'pmpro-email-confirmation' ),

'!!user_login!!' => esc_html__( 'The login name of the user who needs to confirm the email.', 'pmpro-email-confirmation' ),

'!!user_email!!' => esc_html__( 'The email address of the user who needs to confirm the email.', 'pmpro-email-confirmation' ),

Copilot · 2025-10-29T13:28:36Z

+	 * @return string The name of the email recipient.
+	 */
+	public function get_recipient_name() {
+


Remove the empty line with trailing whitespace before the return statement.

Suggested change

Copilot · 2025-10-29T13:28:36Z

-				$body = str_ireplace( "!!validation_link!!", $url, $body );
+		if ( class_exists( 'PMPro_Email_Template' ) ) {
+			$send_resend_confirmation_email	= new PMPro_Email_Template_Resend_Confirmation( $user, $url );
+			$mail_sent_successfully = $send_resend_confirmation_email->send();


When using the new PMPro_Email_Template system (lines 431-433), the success message is never set. The $pmproec_msg and $pmproec_msgt globals are only set within the else block (lines 465-468). This means users won't see a confirmation message when the email is sent using the new template system. Add the success message logic after line 433.

Suggested change

$mail_sent_successfully = $send_resend_confirmation_email->send();

$mail_sent_successfully = $send_resend_confirmation_email->send();

if ( $mail_sent_successfully ) {

$pmproec_msg = esc_html__( 'A confirmation email has been sent to', 'pmpro-email-confirmation' ) . ' ' . $user->user_email;

$pmproec_msgt = 'updated';

}

[ENHANCEMENT] ADD V3.4+ Email Template Approach

57dcbc8

* Create a new class in the hierarchy of the PMPro_Email_Template class * Require the child class if Parent class exists. Add filter to old template otherwise * Call new class if we're in the class exists

andrewlimaza requested a review from Copilot October 29, 2025 13:26

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENHANCEMENT] ADD V3.4+ Email Template Approach#56

[ENHANCEMENT] ADD V3.4+ Email Template Approach#56
MaximilianoRicoTabo wants to merge 1 commit into
strangerstudios:devfrom
MaximilianoRicoTabo:enhancement/overhaul-email-templates-v3.4+

MaximilianoRicoTabo commented Mar 4, 2025 •

edited

Loading

Uh oh!

MaximilianoRicoTabo commented Mar 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	* The parent user.
	* The user receiving the confirmation email.

	* @param WP_User $user The user will receive the email.
	* @param WP_User $user The user who will receive the email.

-			$mail_sent_successfully = $send_resend_confirmation_email->send();
+			$mail_sent_successfully = $send_resend_confirmation_email->send();
+			if ( $mail_sent_successfully ) {
+				$pmproec_msg = esc_html__( 'A confirmation email has been sent to', 'pmpro-email-confirmation' ) . ' ' . $user->user_email;
+				$pmproec_msgt = 'updated';
+			}

Conversation

MaximilianoRicoTabo commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Changelog entry

Uh oh!

MaximilianoRicoTabo commented Mar 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MaximilianoRicoTabo commented Mar 4, 2025 •

edited

Loading