Add dependency guards for PMPro and MemberPress option data

[dparker1005]

Problem

Nothing checked that Paid Memberships Pro is active:

• The Action Scheduler callbacks (pmprompmt_migrate_user, pmprompmt_queue_user_migrations, etc.) instantiate MemberOrder and call PMPro_Action_Scheduler::instance() unconditionally. Deactivating PMPro while migration tasks are still queued causes fatals in the queue runner.
• The toolkit page also assumed mepr_options['integrations'] and mepr_options['custom_fields'] exist — undefined-key warnings / foreach on null when MemberPress options are partial or already cleaned up.

Fix

• ! defined( 'PMPRO_VERSION' ) bail in the menu registration and all four Action Scheduler callbacks.
• isset() + is_array() guards around the two mepr_options array accesses.

cc @flintfromthebasement

🤖 Generated with Claude Code

[flintfromthebasement]

PR: #6 — Add dependency guards for PMPro and MemberPress option data
dparker1005 → dev | 3 files, +29 -2
#6

---

Summary

The guards are correctly placed and solve the stated fatal — ! defined( 'PMPRO_VERSION' ) is the right idiom, and the isset() && is_array() pattern for the mepr_options keys is solid. One issue worth addressing before merge: the Action Scheduler callbacks silently return on bail, which causes AS to mark jobs as "complete" even though nothing actually ran.

---

Issues

• Major pmpro-memberpress-migration-toolkit.php:133–137, 249–253, 277–281, 99–103 — All four AS callbacks bail with a plain return; when PMPro is inactive. Action Scheduler treats a callback that returns without throwing as successfully completed. If PMPro is deactivated mid-migration (plugin conflict, update, accidental deactivation), every queued job drains silently — the AS "complete" list looks clean, but no users or content restrictions were actually migrated. The operator has no signal that anything went wrong and would need to re-run the migration from scratch.

  Fix: throw instead of return so AS marks the job as failed and it's visible in the failed queue:

  if ( ! defined( 'PMPRO_VERSION' ) ) {
      throw new \Exception( 'PMPro inactive — migration task skipped.' );
  }

  Or at minimum add an error_log() before the return so there's a trace. Throwing is better — it makes the failure visible in the AS admin UI and preserves retry semantics.

• Minor pmpro-memberpress-migration-toolkit.php:277 — In pmprompmt_migrate_content_restriction, the bail guard is placed after the global declaration, while the other three functions put the guard before any globals. Cosmetic inconsistency but breaks the visual pattern. Move it above the global line to match.

---

Looks Good

class-pmprompmt-migration-step-users.php:107 and class-pmprompmt-migration-step-other.php:260 — the isset() && is_array() ternary with an array() fallback is the right pattern here; no PHP 8 deprecation exposure from feeding null to foreach.

The guard in pmprompmt_menu() is sufficient to protect pmprompmt_page() — WordPress won't register the page callback if the menu registration bails, so direct URL access gets a clean 403. No need to duplicate the guard there.