fix: 馃悰 .unlink() should not delete empty directories - #1278
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes unlink behavior in the core filesystem so that attempting to unlink a directory (including an empty one) fails with EPERM instead of deleting the directory, and adds regression tests to cover sync/async/promises variants.
Changes:
- Update
Superblock.unlinkto throw anEPERMcreateError(...)when the target node is a directory. - Add
unlinkSynctest coverage for directory paths (empty/non-empty/root), including verifyingerror.code/error.path. - Add coverage confirming that unlinking a symlink to a directory removes only the symlink, not the directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fs-node/src/tests/volume/unlinkSync.test.ts | Adds regression tests asserting directory-unlink behavior is EPERM across APIs and does not delete directories. |
| packages/fs-core/src/Superblock.ts | Prevents unlinking directories by throwing EPERM when link.getNode().isDirectory() is true. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.