Build & release modernization

.github/workflows/build-vs-package.yml

@@ -45,13 +45,10 @@ jobs:
         with:
           ref: ${{ github.event.client_payload.pr_number && format('refs/pull/{0}/merge', github.event.client_payload.pr_number) || github.ref }}
           exclude: samples
-      - uses: microsoft/setup-msbuild@v3
-        with:
-          vs-version: '[18.0,19.0)'
       - name: Build
         run: |
-          msbuild build\Stride.VisualStudio.sln `
-            -restore -nr:false `
+          dotnet build build\Stride.VisualStudio.sln `
+            -nr:false `
             -v:m -p:WarningLevel=0 `
             -p:Configuration=${{ github.event.inputs.build-type || inputs.build-type || 'Debug' }} `
             -p:StrideSkipUnitTests=true `

.github/workflows/build-windows-full-msbuild.yml

@@ -0,0 +1,67 @@
+name: Build Windows (Full, VS MSBuild)
+
+# Desktop-MSBuild fidelity check: builds Stride.sln the way Visual Studio does —
+# .NET Framework MSBuild engine, separate restore (no dotnet-build sugar), VS dev
+# environment so VCINSTALLDIR selects the MSVC native build mode (the
+# WindowsDesktop.vcxproj link path VS users get with the C++ workload). Everything
+# else in CI uses dotnet build (core MSBuild), so without this job the engine that
+# all VS users run would be exercised only at release time.
+
+on:
+  schedule:
+    - cron: '52 4 * * *'
+  workflow_dispatch:
+    inputs:
+      build-type:
+        description: Build Configuration
+        default: Debug
+        type: choice
+        options:
+          - Debug
+          - Release
+  pull_request:
+    # Build-logic paths only: the places engine-compat regressions actually come from.
+    paths:
+      - 'sources/sdk/**'
+      - 'sources/targets/**'
+      - 'sources/native/**'
+      - '.github/workflows/build-windows-full-msbuild.yml'
+
+concurrency:
+  group: build-windows-full-msbuild-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  Windows-MSBuild:
+    name: Build (${{ github.event.inputs.build-type || 'Debug' }}, VS MSBuild)
+    if: github.event_name != 'pull_request' || github.event.pull_request.draft != true
+    runs-on: windows-2025-vs2026
+    timeout-minutes: 60
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          lfs: true
+          submodules: true
+      # VsDevCmd environment (VCINSTALLDIR etc.), exported for the following steps.
+      - uses: ilammy/msvc-dev-cmd@v1
+      - name: Restore
+        # VS restores via its NuGet integration before building; bare /t:Restore is the
+        # CLI equivalent. Same properties as Build so the TFM graph matches.
+        run: |
+          msbuild build\Stride.sln `
+            /t:Restore `
+            /m /nr:false /v:m /p:WarningLevel=0 `
+            /p:Configuration=${{ github.event.inputs.build-type || 'Debug' }} `
+            /p:StridePlatforms=Windows `
+            /p:StrideGraphicsApiDependentBuildAll=true `
+            /p:StrideSkipUnitTests=true `
+            /p:StrideSkipAutoPack=true
+      - name: Build
+        run: |
+          msbuild build\Stride.sln `
+            /m /nr:false /v:m /p:WarningLevel=0 `
+            /p:Configuration=${{ github.event.inputs.build-type || 'Debug' }} `
+            /p:StridePlatforms=Windows `
+            /p:StrideGraphicsApiDependentBuildAll=true `
+            /p:StrideSkipUnitTests=true `
+            /p:StrideSkipAutoPack=true

.github/workflows/main.yml

@@ -45,15 +45,53 @@ jobs:
       || github.repository == 'stride3d/stride'
       || vars.STRIDE_ENABLE_PUSH_CI == 'true'
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: read
     outputs:
-      runtime: ${{ steps.filter.outputs.runtime || 'true' }}
-      ios: ${{ steps.filter.outputs.ios || 'true' }}
-      ios-tests: ${{ steps.filter.outputs.ios-tests || 'true' }}
-      android: ${{ steps.filter.outputs.android || 'true' }}
-      full: ${{ steps.filter.outputs.full || 'true' }}
+      runtime: ${{ steps.comments.outputs.comment_only == 'true' && 'false' || steps.filter.outputs.runtime || 'true' }}
+      ios: ${{ steps.comments.outputs.comment_only == 'true' && 'false' || steps.filter.outputs.ios || 'true' }}
+      ios-tests: ${{ steps.comments.outputs.comment_only == 'true' && 'false' || steps.filter.outputs.ios-tests || 'true' }}
+      android: ${{ steps.comments.outputs.comment_only == 'true' && 'false' || steps.filter.outputs.android || 'true' }}
+      full: ${{ steps.comments.outputs.comment_only == 'true' && 'false' || steps.filter.outputs.full || 'true' }}
     steps:
       - uses: actions/checkout@v4
         if: github.event_name == 'pull_request'
+      # Comment-only PRs skip everything (Gate stays green via skipped jobs). Conservative:
+      # only whole-line comments/blanks in known file types count; anything else (inline
+      # comment edits, unknown extensions, huge/binary patches) runs CI normally. Known
+      # hole: comment-looking lines inside multi-line string literals.
+      - name: Detect comment-only changes
+        id: comments
+        if: github.event_name == 'pull_request'
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          gh api "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/files" --paginate --slurp > /tmp/pr-files.json
+          python3 - <<'EOF' >> "$GITHUB_OUTPUT"
+          import json, os
+          markers = {'.cs': '//', '.yml': '#', '.yaml': '#'}
+          files = [f for page in json.load(open('/tmp/pr-files.json')) for f in page]
+          def comment_only():
+              if len(files) >= 3000:  # API truncates the file list there
+                  return False
+              for f in files:
+                  marker = markers.get(os.path.splitext(f['filename'])[1].lower())
+                  patch = f.get('patch')  # absent for binary/oversized diffs
+                  if marker is None or patch is None:
+                      return False
+                  for line in patch.split('\n'):
+                      if line[:1] in ('+', '-'):
+                          body = line[1:].strip()
+                          # U+2028/29: line terminators to the C# compiler but not to diff;
+                          # code could hide behind a comment marker on the same diff line.
+                          if '\u2028' in body or '\u2029' in body:
+                              return False
+                          if body and not body.startswith(marker):
+                              return False
+              return bool(files)
+          print('comment_only=' + str(comment_only()).lower())
+          EOF
       - uses: dorny/paths-filter@v3
         if: github.event_name == 'pull_request'
         id: filter
@@ -95,8 +133,7 @@ jobs:
               - 'sources/**/*.Android.*'
               - 'sources/**/Platforms/Android/**'
               - 'sources/native/**'
-              - 'sources/sdk/**/Android*'
-              - 'sources/sdk/**/*.Android.*'
+              - 'sources/sdk/**'
               - 'tests/android/**'
               - 'tests/**/Android.Vulkan/**'
               - 'build/Stride.Tests.Game.Android.slnf'

.github/workflows/release-launcher.yml

@@ -11,6 +11,10 @@ on:
         description: Deploy to NuGet.org
         default: false
         type: boolean
+      upload-binlog:
+        description: Capture and upload an MSBuild binlog (diagnostics). Ignored on signed builds — a binlog records env vars/task params and would leak signing secrets.
+        default: false
+        type: boolean
 
 concurrency:
   group: release-launcher-${{ github.ref }}
@@ -82,7 +86,7 @@ jobs:
         run: |
           msbuild build\Stride.build `
             /t:FullBuildLauncher `
-            /bl /m /nr:false `
+            ${{ inputs.upload-binlog && !inputs.sign && '/bl' || '' }} /m /nr:false `
             /p:StrideSign=${{ inputs.sign }}
         env:
           StrideSignTenantId: ${{ secrets.STRIDE_SIGN_TENANT_ID }}
@@ -109,6 +113,14 @@ jobs:
             bin/launcher/*.exe
           retention-days: 30
 
+      - name: Upload build log
+        uses: actions/upload-artifact@v4
+        if: ${{ always() && inputs.upload-binlog && !inputs.sign }}
+        with:
+          name: build-log
+          path: msbuild.binlog
+          if-no-files-found: ignore
+
   Deploy:
     name: Deploy Launcher
     if: ${{ inputs.deploy && inputs.sign }}

.github/workflows/release-vspackage.yml

@@ -11,6 +11,10 @@ on:
         description: Deploy to NuGet.org
         default: false
         type: boolean
+      upload-binlog:
+        description: Capture and upload an MSBuild binlog (diagnostics). Ignored on signed builds — a binlog records env vars/task params and would leak signing secrets.
+        default: false
+        type: boolean
 
 concurrency:
   group: release-vspackage-${{ github.ref }}
@@ -60,14 +64,14 @@ jobs:
             6.0.x
             10.0.x
 
-      - uses: microsoft/setup-msbuild@v2
-
       - name: Build VS Package
         run: |
-          msbuild build\Stride.build `
-            /t:VSIXPlugin `
-            /bl /m /nr:false `
-            /p:StrideSign=${{ inputs.sign }}
+          # --no-restore: the VSIXPlugin target restores its solution itself.
+          dotnet build build\Stride.build `
+            -t:VSIXPlugin `
+            --no-restore `
+            ${{ inputs.upload-binlog && !inputs.sign && '-bl' || '' }} -m -nr:false `
+            -p:StrideSign=${{ inputs.sign }}
         env:
           StrideSignTenantId: ${{ secrets.STRIDE_SIGN_TENANT_ID }}
           StrideSignClientId: ${{ secrets.STRIDE_SIGN_CLIENT_ID }}
@@ -92,6 +96,14 @@ jobs:
           if-no-files-found: error
           retention-days: 30
 
+      - name: Upload build log
+        uses: actions/upload-artifact@v4
+        if: ${{ always() && inputs.upload-binlog && !inputs.sign }}
+        with:
+          name: build-log
+          path: msbuild.binlog
+          if-no-files-found: ignore
+
   Deploy:
     name: Deploy VS Package
     if: ${{ inputs.deploy && inputs.sign }}