Skip to content
This repository was archived by the owner on Dec 22, 2020. It is now read-only.

avoid logging creating table if the table is not actually created#58

Open
AndreaCrotti wants to merge 1 commit into
stripe-archive:masterfrom
AndreaCrotti:skip_logging_if_not_creating_table
Open

avoid logging creating table if the table is not actually created#58
AndreaCrotti wants to merge 1 commit into
stripe-archive:masterfrom
AndreaCrotti:skip_logging_if_not_creating_table

Conversation

@AndreaCrotti
Copy link
Copy Markdown

No description provided.

@AndreaCrotti
Copy link
Copy Markdown
Author

Any news about this very simple change?
I don't think the travis build is affected by this right?

@nelhage
Copy link
Copy Markdown
Contributor

nelhage commented Nov 17, 2014

Hm, clobber doesn't seem like the right test. How would you feel about either:

  • Changing the text to "ensuring table exists"
  • Guarding with a if !db.table_exists?

?

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants