When available, support adding bank accounts as first link payment method#6218
Open
josephroque-stripe wants to merge 1 commit intomasterfrom
Open
When available, support adding bank accounts as first link payment method#6218josephroque-stripe wants to merge 1 commit intomasterfrom
josephroque-stripe wants to merge 1 commit intomasterfrom
Conversation
| // Show a loading view while Financial Connections is being prepared | ||
| viewController = LoaderViewController(context: context) | ||
| } else { | ||
| let addPaymentMethodVC = NewPaymentViewController( |
Contributor
There was a problem hiding this comment.
Checking my understanding: We're removing this because when more than just bank accounts are supported and the user has no payment methods, we'll just show the wallet (line 519) so they can add any of the supported types. Is that right?
Collaborator
|
Looks good, but I found an issue when tapping the Pay button when there are no payment methods. Most likely wasn't introduced in this PR, but because this PR starts showing the empty wallet screen much more often, it feels like something we should fix here: Screen.Recording.2026-03-20.at.11.03.13.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When available as a supported payment method, allow new link users to add a bank account as a payment method, instead of requiring a card first.
Motivation
When a user creates a new link account, currently we require they add a card as a first payment method, but this requirement doesn't exist on web. On web, if the checkout supports bank accounts, then the user can add a bank account as a first payment method instead.
https://jira.corp.stripe.com/browse/RUN_LINK_MOBILE-96
Testing
Manually testing the flow with a new account