increase testSavedSepa network response allowance 10->15 seconds#6237
increase testSavedSepa network response allowance 10->15 seconds#6237gbirch-stripe wants to merge 1 commit intomasterfrom
Conversation
joyceqin-stripe
left a comment
There was a problem hiding this comment.
I think a change I made recently may have impacted this 😅 Previously, this test used a hard-coded customer, but every so often, the no-mocks tests would start failing due to the customer reaching the max limit for payment methods attached. I made a change when we ran into that issue again to create a new customer and payment method to attach to that customer instead of reusing a hardcoded one.
I think increasing the timeout should fix it most of the time, but if you look at run 2 of this failure, you see "PaymentSheet.confirm failed - Error creating PaymentIntent: This object cannot be accessed right now because another API request or Stripe process is currently accessing it." I think maybe we need a mechanism before the PaymentSheet confirm intent loop to make sure previous API calls are finished before making another, maybe just a sleep or something?
Summary
testSavedSepa has been failing in the nightly no-mocks CI run with a timeout failure. this happens inconsistently, indicating that it is a true timeout. increasing the allowance to see if this corrects it
Motivation
Testing
Changelog