Skip to content

increase testSavedSepa network response allowance 10->15 seconds#6237

Open
gbirch-stripe wants to merge 1 commit intomasterfrom
gbirch/increase-testSavedSepa-allowance
Open

increase testSavedSepa network response allowance 10->15 seconds#6237
gbirch-stripe wants to merge 1 commit intomasterfrom
gbirch/increase-testSavedSepa-allowance

Conversation

@gbirch-stripe
Copy link
Copy Markdown
Collaborator

Summary

testSavedSepa has been failing in the nightly no-mocks CI run with a timeout failure. this happens inconsistently, indicating that it is a true timeout. increasing the allowance to see if this corrects it

Motivation

Testing

Changelog

@gbirch-stripe gbirch-stripe requested review from a team as code owners March 21, 2026 00:15
@gbirch-stripe gbirch-stripe requested review from a team and porter-stripe and removed request for a team March 21, 2026 00:16
Copy link
Copy Markdown
Collaborator

@joyceqin-stripe joyceqin-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a change I made recently may have impacted this 😅 Previously, this test used a hard-coded customer, but every so often, the no-mocks tests would start failing due to the customer reaching the max limit for payment methods attached. I made a change when we ran into that issue again to create a new customer and payment method to attach to that customer instead of reusing a hardcoded one.

I think increasing the timeout should fix it most of the time, but if you look at run 2 of this failure, you see "PaymentSheet.confirm failed - Error creating PaymentIntent: This object cannot be accessed right now because another API request or Stripe process is currently accessing it." I think maybe we need a mechanism before the PaymentSheet confirm intent loop to make sure previous API calls are finished before making another, maybe just a sleep or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants