-
Notifications
You must be signed in to change notification settings - Fork 1k
CheckoutSessions — top level Setup Future Usage #6292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gbirch-stripe
wants to merge
6
commits into
master
Choose a base branch
from
gbirch/cs-pr2-top-level-sfu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
df70232
Add checkout session top-level setup_future_usage
gbirch-stripe 332a62b
rename and rework parsing of setupFutureUsage CS property
gbirch-stripe e9de25d
add assertions for subscription/unknown
gbirch-stripe 99b04be
don't assert on isPaymentMethodOptionsSetupFutureUsageSet analytic value
gbirch-stripe 8ae4528
remove extraneous tests that were testing unsupported behavior
gbirch-stripe 8ed4975
Merge branch 'master' into gbirch/cs-pr2-top-level-sfu
gbirch-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,19 @@ import StripePaymentsObjcTestUtils | |
| import XCTest | ||
|
|
||
| class STPCheckoutSessionTest: XCTestCase { | ||
| private func makeCheckoutSession(_ overrides: [String: Any]) -> STPCheckoutSession { | ||
| var json: [String: Any] = [ | ||
| "session_id": "cs_test", | ||
| "object": "checkout.session", | ||
| "livemode": false, | ||
| "mode": "payment", | ||
| "payment_status": "unpaid", | ||
| "payment_method_types": ["card"], | ||
| "customer": ["id": "cus_123"], | ||
| ] | ||
| overrides.forEach { json[$0.key] = $0.value } | ||
| return STPCheckoutSession.decodedObject(fromAPIResponse: json)! | ||
| } | ||
|
|
||
| // MARK: - STPAPIResponseDecodable Tests | ||
|
|
||
|
|
@@ -81,6 +94,7 @@ class STPCheckoutSessionTest: XCTestCase { | |
| XCTAssertNotNil(session.savedPaymentMethodsOfferSave) | ||
| XCTAssertTrue(session.savedPaymentMethodsOfferSave!.enabled) | ||
| XCTAssertEqual(session.savedPaymentMethodsOfferSave!.status, .notAccepted) | ||
| XCTAssertNil(session.setupFutureUsage) | ||
|
|
||
| XCTAssertEqual( | ||
| session.paymentMethodTypes, | ||
|
|
@@ -189,6 +203,7 @@ class STPCheckoutSessionTest: XCTestCase { | |
| XCTAssertNil(session?.url) | ||
| XCTAssertNil(session?.returnUrl) | ||
| XCTAssertNil(session?.savedPaymentMethodsOfferSave) | ||
| XCTAssertNil(session?.setupFutureUsage) | ||
| } | ||
|
|
||
| func testDecodedObjectWithSetupMode() { | ||
|
|
@@ -213,6 +228,14 @@ class STPCheckoutSessionTest: XCTestCase { | |
| XCTAssertNil(session?.paymentIntentId) | ||
| } | ||
|
|
||
| func testDecodedObjectParsesTopLevelSetupFutureUsage() { | ||
| let session = makeCheckoutSession([ | ||
| "setup_future_usage": "off_session", | ||
| ]) | ||
|
|
||
| XCTAssertEqual(session.setupFutureUsage, "off_session") | ||
| } | ||
|
|
||
| func testTotalsWithTaxFromTaxAmounts() { | ||
| let json: [String: Any] = [ | ||
| "session_id": "cs_test_tax", | ||
|
|
@@ -282,6 +305,21 @@ class STPCheckoutSessionTest: XCTestCase { | |
| XCTAssertFalse(session.merchantWillSavePaymentMethod(.card)) | ||
| } | ||
|
|
||
| func testMerchantWillSavePaymentMethod_paymentModeWithTopLevelSetupFutureUsage() { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it worth adding a test for |
||
| let session = STPCheckoutSession.decodedObject(fromAPIResponse: [ | ||
| "session_id": "cs_test_payment_sfu", | ||
| "object": "checkout.session", | ||
| "livemode": false, | ||
| "mode": "payment", | ||
| "payment_status": "unpaid", | ||
| "payment_method_types": ["card"], | ||
| "customer": ["id": "cus_123"], | ||
| "setup_future_usage": "off_session", | ||
| ])! | ||
|
|
||
| XCTAssertTrue(session.merchantWillSavePaymentMethod(.card)) | ||
| } | ||
|
|
||
| func testMerchantWillSavePaymentMethod_paymentModeWithoutCustomer() { | ||
| let session = STPCheckoutSession.decodedObject(fromAPIResponse: [ | ||
| "session_id": "cs_test_payment_no_customer", | ||
|
|
@@ -322,4 +360,36 @@ class STPCheckoutSessionTest: XCTestCase { | |
|
|
||
| XCTAssertFalse(session.merchantWillSavePaymentMethod(.card)) | ||
| } | ||
|
|
||
| func testMerchantWillSavePaymentMethod_subscriptionModeWithCustomer() { | ||
| let session = STPCheckoutSession.decodedObject(fromAPIResponse: [ | ||
| "session_id": "cs_test_subscription", | ||
| "object": "checkout.session", | ||
| "livemode": false, | ||
| "mode": "subscription", | ||
| "payment_status": "unpaid", | ||
| "payment_method_types": ["card"], | ||
| "customer": ["id": "cus_123"], | ||
| ])! | ||
|
|
||
| XCTAssertTrue(session.merchantWillSavePaymentMethod(.card)) | ||
| } | ||
|
|
||
| func testCheckoutSessionIntent_setupFutureUsageString() { | ||
| let session = makeCheckoutSession([ | ||
| "setup_future_usage": "off_session", | ||
| ]) | ||
|
|
||
| XCTAssertEqual(Intent.checkoutSession(session).setupFutureUsageString, "off_session") | ||
| } | ||
|
|
||
| func testCheckoutSessionIntent_isSetupFutureUsageSet_topLevel() { | ||
| let session = makeCheckoutSession([ | ||
| "setup_future_usage": "off_session", | ||
| "payment_method_types": ["paypal"], | ||
| ]) | ||
|
|
||
| XCTAssertTrue(Intent.checkoutSession(session).isSetupFutureUsageSet(for: .payPal)) | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PMO SFU logic will go here