Fix vending card art by fixing pre-caching image#6338
Open
wooj-stripe wants to merge 2 commits intomasterfrom
Open
Fix vending card art by fixing pre-caching image#6338wooj-stripe wants to merge 2 commits intomasterfrom
wooj-stripe wants to merge 2 commits intomasterfrom
Conversation
yuki-stripe
reviewed
Apr 14, 2026
| guard let matchingPaymentMethod = paymentMethods.first(where: { $0.stripeId == paymentMethodId }) else { | ||
| return nil | ||
| } | ||
| matchingPaymentMethod.preloadCardArtImage(cardArtEnabled: configuration.appearance.cardArtEnabled) |
Collaborator
There was a problem hiding this comment.
I thought the idea was to block this on downloading the card art, since it's already async?
Collaborator
Author
There was a problem hiding this comment.
Doing so would slow down this function as well as be inconsistent with the behavior of payment sheet, so I ultimately decided against doing this.
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentOption+Images.swift
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentOption+Images.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentOption+Images.swift
Outdated
Show resolved
Hide resolved
| defaultPaymentMethod: elementsSession.customer?.getDefaultPaymentMethod() | ||
| ) | ||
|
|
||
| // Pre-fetch card art without waiting for this to finish |
Collaborator
There was a problem hiding this comment.
I think you said pre-loading payment option images in general was broken, is that still true?
Collaborator
Author
There was a problem hiding this comment.
Correct in FlowController.swift, _ = flowController.paymentOption does not seem to have any effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vending card art through our APIs by prefetching on load or when accessed on CustomerSheet retrievePaymentOptionSelection() api. When vending, APIs return back what we currently have in cache. Approach is "best-effort" to reduce impact on loading payment sheet/customersheet.
Motivation
Currently working only if the image happens to make itself into the cache
Testing
Updated tests & manual testing
Changelog