This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Open
Conversation
Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requestscc @stripe/observability |
ChimeraCoder
force-pushed
the
aditya-gotest
branch
from
d3150a7 to
4049095
Compare
ChimeraCoder
force-pushed
the
aditya-gotest
branch
from
4049095 to
7828cab
Compare
|
gotest seems to have a minor issue on Travis, can you hold this PR for a while until I diagnose and address it? |
Contributor
Author
|
Oh snap - sure thing. Thanks for letting us know. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use gotest (courtesy of @rakyll) for Travis CI builds.
Travis CI sometimes flakes because it runs in weird, resource-constrained environments. That's itself an annoyance we should figure out a solution for, but at the very least this will make it easier for us to spot those failures when they happen.
Motivation
Test plan
Rollout/monitoring/revert plan
r? @stripe/observability