fix: cancel YES order when NO order fails#2
Open
asm554 wants to merge 1 commit into
Open
Conversation
If NO order placement fails after YES order succeeds, the bot now attempts to cancel the YES order via bot.cancel_order(). If cancellation also fails, a CRITICAL log is emitted for manual intervention. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the YES order succeeds but the NO order fails, the bot returned
Falsewithout cancelling the open YES order. This left an unhedged position on a binary market — real financial risk.Fix
The bot now attempts to cancel the YES order via
bot.cancel_order()(already implemented insrc/bot.py). If cancellation fails or no order ID is available, aCRITICALlog is emitted for manual intervention.Test plan
CRITICALlog appears whenbot.cancel_order()returnsFalse🤖 Generated with Claude Code