Improve CI reliability and drop Node 18 support - #182
Merged
Conversation
radubahmata
changed the title
radubahmata
force-pushed
the
ci/fix-json-error
branch
from
September 25, 2025 13:36
aa00c86 to
414c2bb
Compare
moodmosaic
reviewed
Sep 30, 2025
moodmosaic
left a comment
moodmosaic
left a comment
Contributor
There was a problem hiding this comment.
This looks good. The only reason I can see for the draft status is the incomplete teardown in some tests.
This commit reduces test parallelization using `maxWorkers` config option, moves the testTimeout to jest.config.js, and updates the coverage config.
Contributor
Author
@moodmosaic That was not actually the case. The teardown was already in place on master, so it doesn’t show up in the diff. The real issue was CI failing even after the changes, which should now be fixed. That said, GitHub reported some workflow issues causing macOS jobs to stay pending: https://www.githubstatus.com/incidents/071h21gptcp0 Once CI is green, this PR can come out of draft. |
radubahmata
changed the title
Contributor
Author
|
This PR seems to successfully solve the flakiness in the tests as a CI step. Taking it out of draft. |
radubahmata
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves CI stability and modernizes the test setup. It removes Node.js 18 support, adds Node.js 23, and ensures tests run reliably in isolated environments.
More specifically, this PR:
createIsolatedTestEnvironmentutility to prevent race conditions in tests requiring simnet sessionsjest.setup.jswhich ensures that theexampleClarinet project cache and deployment plan are initialized before all the tests runpackage.jsonAddresses #172.