[D] Fix auto attribute in if and while conditions#4568
Merged
Conversation
This commit adds `auto` keyword to `first-value`.
This commit removes redundant pattern as `auto` is part of `attributes` variable and therefore already included via `attribute_lookahead` context.
Collaborator
|
not a fan of the mix of |
michaelblyons
approved these changes
Jun 14, 2026
jrappen
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4567
This PR removes a redundant
autopattern frombasic-typecontext and adds a specialcondition-attributecontext to consume it at the beginning ofifandwhileconditions.Note: Adding
condition-attributecontext is a conservative decision to avoid undesired side-effects. It may also be valid to prependautopattern tofirst-value.