[ShellScript] Separate glob and regexp scopes#4571
Open
deathaxe wants to merge 3 commits into
Open
Conversation
This commit adjusts character class related scopes. Character classes were scoped `meta.set` with the name `charset` in mind, which is however something totally different. Note: This commit does not rename context names due to compatibility concerns with 3rd-party packages.
Copy character class contexts from glob patterns to eregexp in preparation of separating scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR...
aligns glob pattern matching related scopes with PR [Git Formats] Add support for full glob patterns #4569
meta.character-classinstead ofmeta.set(to be applied to other RegExp syntaxes in future PRs)
fully separates glob and (e)regexp patterns, with regards to contexts and scope names.
Glob patterns are finalized with
.glob.shellRegular Expressions are finalized with
.regexp.shell