Copy diagnostic hover text

boot.py

@@ -56,6 +56,7 @@
 from .plugin.hierarchy import LspCallHierarchyCommand
 from .plugin.hierarchy import LspHierarchyToggleCommand
 from .plugin.hierarchy import LspTypeHierarchyCommand
+from .plugin.hover import LspCopyTextCommand
 from .plugin.hover import LspHoverCommand
 from .plugin.hover import LspToggleHoverPopupsCommand
 from .plugin.inlay_hint import LspInlayHintClickCommand
@@ -158,6 +159,7 @@
     "LspUpdateLogPanelCommand",
     "LspUpdatePanelCommand",
     "LspWorkspaceSymbolsCommand",
+    'LspCopyTextCommand',
     "TextChangeListener",
     "plugin_loaded",
     "plugin_unloaded",

plugin/completion.py

@@ -3,13 +3,13 @@
 from .core.edit import apply_text_edits
 from .core.logging import debug
 from .core.promise import Promise
-from .core.protocol import EditRangeWithInsertReplace
 from .core.protocol import CompletionItem
 from .core.protocol import CompletionItemDefaults
 from .core.protocol import CompletionItemKind
 from .core.protocol import CompletionItemTag
 from .core.protocol import CompletionList
 from .core.protocol import CompletionParams
+from .core.protocol import EditRangeWithInsertReplace
 from .core.protocol import Error
 from .core.protocol import InsertReplaceEdit
 from .core.protocol import InsertTextFormat
@@ -20,7 +20,9 @@
 from .core.registry import LspTextCommand
 from .core.sessions import Session
 from .core.settings import userprefs
+from .core.views import copy_text_html
 from .core.views import FORMAT_STRING, FORMAT_MARKUP_CONTENT
+from .core.views import markup_to_string
 from .core.views import MarkdownLangMap
 from .core.views import minihtml
 from .core.views import range_to_region
@@ -303,9 +305,9 @@ def _handle_resolve_response_async(self, language_map: MarkdownLangMap | None, i
             documentation = self._format_documentation(markdown, None)
         minihtml_content = ""
         if detail:
-            minihtml_content += f"<div class='highlight'>{detail}</div>"
+            minihtml_content += copy_text_html(f"<div class='highlight'>{detail}</div>", copy_text=item.get('detail'))
         if documentation:
-            minihtml_content += documentation
+            minihtml_content += copy_text_html(documentation, markup_to_string(item.get("documentation") or ""))
 
         def run_main() -> None:
             if not self.view.is_valid():

plugin/core/signature_help.py

@@ -3,7 +3,7 @@
 from .protocol import SignatureHelp
 from .protocol import SignatureInformation
 from .registry import LspTextCommand
-from .views import FORMAT_MARKUP_CONTENT
+from .views import FORMAT_MARKUP_CONTENT, copy_text_html, markup_to_string
 from .views import FORMAT_STRING
 from .views import MarkdownLangMap
 from .views import minihtml
@@ -83,7 +83,7 @@ def render(self, view: sublime.View) -> str:
         else:
             self._active_parameter_bold = active_parameter_style.get('bold', False)
             self._active_parameter_underline = active_parameter_style.get('underline', False)
-        formatted.extend(self._render_label(signature))
+        formatted.append(self._render_label(signature))
         formatted.extend(self._render_docs(view, signature))
         return "".join(formatted)
 
@@ -111,7 +111,7 @@ def _render_intro(self) -> str:
             len(self._signatures),
         )
 
-    def _render_label(self, signature: SignatureInformation) -> list[str]:
+    def _render_label(self, signature: SignatureInformation) -> str:
         formatted: list[str] = []
         # Note that this <div> class and the extra <pre> are copied from mdpopups' HTML output. When mdpopups changes
         # its output style, we must update this literal string accordingly.
@@ -147,7 +147,7 @@ def _render_label(self, signature: SignatureInformation) -> list[str]:
         else:
             formatted.append(self._function(label))
         formatted.append("</pre></div>")
-        return formatted
+        return copy_text_html("".join(formatted), label)
 
     def _render_docs(self, view: sublime.View, signature: SignatureInformation) -> list[str]:
         formatted: list[str] = []
@@ -175,14 +175,14 @@ def _parameter_documentation(self, view: sublime.View, signature: SignatureInfor
         documentation = parameter.get("documentation")
         if documentation:
             allowed_formats = FORMAT_STRING | FORMAT_MARKUP_CONTENT
-            return minihtml(view, documentation, allowed_formats, self._language_map)
+            return copy_text_html(minihtml(view, documentation, allowed_formats, self._language_map), copy_text=markup_to_string(documentation))
         return None
 
     def _signature_documentation(self, view: sublime.View, signature: SignatureInformation) -> str | None:
         documentation = signature.get("documentation")
         if documentation:
             allowed_formats = FORMAT_STRING | FORMAT_MARKUP_CONTENT
-            return minihtml(view, documentation, allowed_formats, self._language_map)
+            return copy_text_html(minihtml(view, documentation, allowed_formats, self._language_map), copy_text=markup_to_string(documentation))
         return None
 
     def _function(self, content: str) -> str:

plugin/core/views.py

@@ -820,9 +820,9 @@ def _html_element(name: str, text: str, class_name: str | None = None, escape: b
 
 
 def format_diagnostic_for_html(config: ClientConfig, diagnostic: Diagnostic, base_dir: str | None = None) -> str:
-    html = _html_element('span', diagnostic["message"])
     code = diagnostic.get("code")
-    source = diagnostic.get("source")
+    source = diagnostic.get("source") or ""
+    html = copy_text_html(_html_element('span', diagnostic["message"]), copy_text=f"{source} {diagnostic['message']}")
     if source or code is not None:
         meta_info = ""
         if source:
@@ -840,6 +840,25 @@ def format_diagnostic_for_html(config: ClientConfig, diagnostic: Diagnostic, bas
     return _html_element("pre", html, class_name=severity_class, escape=False)
 
 
+def markup_to_string(content: MarkupContent | MarkedString | list[MarkedString]) -> str:
+    if isinstance(content, str):
+        return content
+    elif isinstance(content, dict):
+        return content.get('value', '')
+    elif isinstance(content, list):
+        return " ".join(content)   # pyright: ignore[reportCallIssue, reportUnknownVariableType, reportArgumentType]
+
+
+def copy_text_html(html_content: str, copy_text: str | None = None) -> str:
+    if copy_text is None:
+        copy_text = html_content
+    return f"""<a title="Click to Copy"
+       style='text-decoration: none; display: block; color: var(--foreground)'
+       href='{sublime.command_url('lsp_copy_text', {
+        'text': html.unescape(copy_text.replace(' ', ' '))
+       })}'>{html_content}</a>"""
+
+
 def format_code_actions_for_quick_panel(
     session_actions: Iterable[tuple[str, CodeAction | Command]]
 ) -> tuple[list[sublime.QuickPanelItem], int]:

plugin/hover.py

@@ -13,6 +13,8 @@
 from .core.protocol import DocumentLink
 from .core.protocol import Error
 from .core.protocol import Hover
+from .core.protocol import MarkedString
+from .core.protocol import MarkupContent
 from .core.protocol import Position
 from .core.protocol import Range
 from .core.protocol import Request
@@ -23,11 +25,13 @@
 from .core.sessions import SessionBufferProtocol
 from .core.settings import userprefs
 from .core.url import parse_uri
+from .core.views import copy_text_html
 from .core.views import diagnostic_severity
 from .core.views import format_code_actions_for_quick_panel
 from .core.views import format_diagnostic_for_html
 from .core.views import FORMAT_MARKED_STRING
 from .core.views import FORMAT_MARKUP_CONTENT
+from .core.views import markup_to_string
 from .core.views import is_location_href
 from .core.views import make_command_link
 from .core.views import make_link
@@ -46,7 +50,6 @@
 import sublime
 import sublime_plugin
 
-
 SessionName = str
 ResolvedHover = Union[Hover, Error]
 
@@ -259,11 +262,14 @@ def diagnostics_content(self) -> str:
         return "".join(formatted)
 
     def hover_content(self) -> str:
-        contents = []
+        contents: list[str] = []
         for hover, language_map in self._hover_responses:
             content = (hover.get('contents') or '') if isinstance(hover, dict) else ''
             allowed_formats = FORMAT_MARKED_STRING | FORMAT_MARKUP_CONTENT
-            contents.append(minihtml(self.view, content, allowed_formats, language_map))
+            html_content = minihtml(self.view, content, allowed_formats, language_map)
+            copy_text = markup_to_string(content)
+            html_content = copy_text_html(html_content, copy_text)
+            contents.append(html_content)
         return '<hr>'.join(contents)
 
     def hover_range(self) -> sublime.Region | None:
@@ -420,3 +426,8 @@ def _update_views_async(self, enable: bool) -> None:
                     session_view.view.settings().set(SHOW_DEFINITIONS_KEY, False)
                 else:
                     session_view.reset_show_definitions()
+
+
+class LspCopyTextCommand(sublime_plugin.TextCommand):
+    def run(self, edit, text: str) -> None:
+        sublime.set_clipboard(text)