Introduce LspPlugin.on_transport_ready#2942
Draft
rwols wants to merge 1 commit into
Draft
Conversation
rwols
changed the title
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Uhm... how do I change the base branch? |
Member
Author
|
OK. You have to click the "Edit Title" button to change the base branch these days... |
Also collapse StreamTransport into Transport because there is only one Transport now.
rwols
force-pushed
the
feat/transport-ready-api
branch
from
7db308f to
99a206c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the async method
on_transport_readytoLspPlugin. It takes anasyncio.StreamReaderandasyncio.StreamWriterallowing one to interact with the transport before JSON-RPC communication starts.Returning from the async method means that the JSON-RPC communication can start.
.
Depends on #2880.