Skip to content

Allow pylsp and pyrefly to work with this repository #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwols merged 2 commits into from
Jun 18, 2026
+9 −0
Merged

Allow pylsp and pyrefly to work with this repository #2955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ebeb88
Allow pylsp and pyrefly to work with this repository
rwols Jun 14, 2026
821b3d4
Forget about pylsp
rwols Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,12 @@ ignore = [
"TRY003", # https://docs.astral.sh/ruff/rules/raise-vanilla-args/
"TRY301", # https://docs.astral.sh/ruff/rules/raise-within-try/
]

[tool.pyrefly]
python-version = "3.8.0"
site-package-path = ["./stubs"]
infer-with-first-use = false

[tool.pyrefly.errors]
bad-override = "ignore"
missing-source = "ignore"
Comment on lines +154 to +161

@rchl rchl Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with introducing those as a means of evaluating different type checkers (there is also ty). I'm not super confident that pyright has a bright future.

@rchl rchl Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, please adapt the configuration so that there is not a ton of errors when running pyrefly check. Ignoring errors in tests and third_party would be a start.

@rwols rwols Jun 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to remove some initial friction when browsing the repository with a pyrefly config enabled. But I could add some disabled checks. I actually haven’t ran pyrefly in lint mode from the CLI for this. Nor do I think we should engage further in adding this to CI.

Loading