fix(isthmus): preserve CTAS creation policies - #1266
Draft
bvolpato wants to merge 1 commit into
Draft
Conversation
Plain CREATE TABLE AS SELECT and CREATE TABLE IF NOT EXISTS currently emit REPLACE_IF_EXISTS, allowing a consumer to replace an existing table when the SQL requests an error or a no-op. Carry ERROR_IF_EXISTS, IGNORE_IF_EXISTS, and REPLACE_IF_EXISTS from the SQL flags through CreateTable, planner copies, and both conversion directions. Include the mode in planner digests so different creation policies remain distinct. Explicit replacement requires CREATE OR REPLACE TABLE; existing programmatic constructors retain their historical replacement behavior. These policies map to the CTAS creation modes defined by Substrait v0.102.0. Conflicting SQL flags are rejected.
bvolpato
force-pushed
the
bvolpato/fix-ctas-create-mode
branch
from
September 4, 2026 16:27
7af5f67 to
7aa6240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain CREATE TABLE AS SELECT and CREATE TABLE IF NOT EXISTS currently emit REPLACE_IF_EXISTS, allowing a consumer to replace an existing table when the SQL requests an error or a no-op.
Carry ERROR_IF_EXISTS, IGNORE_IF_EXISTS, and REPLACE_IF_EXISTS from the SQL flags through CreateTable, planner copies, and both conversion directions. Include the mode in planner digests so different creation policies remain distinct. Explicit replacement requires CREATE OR REPLACE TABLE; existing programmatic constructors retain their historical replacement behavior.
These policies map to the CTAS creation modes defined by Substrait v0.102.0. Conflicting SQL flags are rejected.