fix: improve error message formatting in setSynthVolume#6698
fix: improve error message formatting in setSynthVolume#6698CodeBySayak wants to merge 4 commits into
Conversation
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
hy jest is faling take a look |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
jest faling still |
|
✅ All Jest tests passed! This PR is ready to merge. Coverage: Coverage summary unavailable |
|
@Ashutoshx7 can you review again I have passed jest tests |
|
Please put the phrasemaker changes into a separate PR |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Coverage: Coverage summary unavailable Failed Tests: |
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Coverage: Coverage summary unavailable Failed Tests: |
# Conflicts: # jest.config.js
|
Merge conflicts resolved. Ready for review. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Coverage: Statements: 41.9% | Branches: 34.79% | Functions: 46.55% | Lines: 42.3% Failed Tests: |
Description
This PR fixes a malformed error message in the
setSynthVolumemethod withinjs/turtleactions/VolumeActions.js.The Problem
When the
setSynthVolumefunction fails to identify a synthesizer or instrument name, it attempts to display an error message to the user. However, the existing code was using thesynthvariable—which is explicitlynullat that point in the logic—instead of the actual input string (synthname). Additionally, the message lacked a space and proper localization support.Original Buggy Output:
nullnot foundChanges
synthname(the actual user-provided input)._()translation helper to ensure it is correctly localized for all users.Testing
Type of Change
closes #6697