fix:Localize record dropdown menu options and fix loader Japanese support#7514
Merged
walterbender merged 1 commit intoJun 13, 2026
Merged
Conversation
Contributor
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 49.12% | Branches: 40.54% | Functions: 53.32% | Lines: 49.53% |
3d11d8c to
867866d
Compare
Contributor
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 49.12% | Branches: 40.54% | Functions: 53.32% | Lines: 49.53% |
Contributor
Author
|
@walterbender can pls you review this |
unmeshgb
pushed a commit
to unmeshgb/musicblocks
that referenced
this pull request
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category :
Description
This PR localizes the hardcoded record dropdown menu options in the user interface by leveraging the existing i18next localization setup.
Key Changes
UI String Localization:
data-i18nattributes to the record options inindex.htmlto hook them into the translation engine:"Record canvas and toolbars""Record canvas only"Loader Integration:
js/loader.jsto dynamically translate elements tagged withdata-i18n.js/loader.js(updateContent()) to handle complex locale objects (such as Japanese, which resolves to a{kanji, kana}structure), preventing[object Object]displaying on-screen.Translation Updates:
po/directory.#. AUTOTRANSLATED: AImarker in the.pofiles..pofiles into their respective.jsonfiles inside thelocales/directory.Before :
After :
Testing & Quality Checks
npm test), confirming all 165 test suites and 5,491 tests pass successfully.