Fix localized solfege labels#7519
Merged
walterbender merged 2 commits intoJun 21, 2026
Merged
Conversation
Contributor
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 49.14% | Branches: 40.57% | Functions: 53.37% | Lines: 49.55% |
Contributor
Author
|
Hey @walterbender can you please review this . |
Member
|
I worry a bit that some of these strings are pretty long. They might look funny in the pie menus. Have you check any of them? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7519 +/- ##
==========================================
+ Coverage 50.52% 50.54% +0.01%
==========================================
Files 163 163
Lines 56586 56605 +19
==========================================
+ Hits 28591 28611 +20
+ Misses 27995 27994 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
36c3a6c to
8e4e68e
Compare
8e4e68e to
909fbe6
Compare
unmeshgb
pushed a commit
to unmeshgb/musicblocks
that referenced
this pull request
Jul 3, 2026
* fix(i18n): localize solfege labels * fix(i18n): warn on missing solfege translations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category :
Summary
Fix localized solfege pitch labels so note names such as
sol,fa,mi,re, anddodisplay in the selected language when a valid translation exists.Changes
ti la sol fa mi re doi18nSolfege()to:convert_po_to_json.pyso malformed solfege translations do not produce broken locale JSON.Affected Locales
Updated solfege entries for:
am,ar,bg,bn,de,dz,el,fa,he,hy,ibo,ka,kn,ko,ml,mn,ru,si,ta,th,ur,zh_CN,zh_TWBefore :
After :