Skip to content

fix: improve palette text contrast on hover across all themes#7655

Open
samson1299 wants to merge 2 commits into
sugarlabs:masterfrom
samson1299:fix/palette-hover-text-contrast
Open

fix: improve palette text contrast on hover across all themes#7655
samson1299 wants to merge 2 commits into
sugarlabs:masterfrom
samson1299:fix/palette-hover-text-contrast

Conversation

@samson1299

@samson1299 samson1299 commented Jun 25, 2026

Copy link
Copy Markdown

Fixes #6439

This pull request improves the readability of palette button labels by ensuring the text color updates correctly when users hover over buttons across all supported themes.

  • Bug Fix
  • Feature
  • Performance
  • Tests
  • Documentation
  • CI/CD

@samson1299 samson1299 requested a review from walterbender as a code owner June 25, 2026 06:05
@github-actions github-actions Bot added bug fix Fixes a bug or incorrect behavior size/XS Extra small: < 10 lines changed area/javascript Changes to JS source files labels Jun 25, 2026
@walterbender

Copy link
Copy Markdown
Member

hmm. We are migrating away from platformcolors.js. Also, please include some before/after screenshots.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.55%. Comparing base (cf5df87) to head (b607fb1).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
js/palette.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7655      +/-   ##
==========================================
- Coverage   54.56%   54.55%   -0.01%     
==========================================
  Files         172      172              
  Lines       57212    57213       +1     
==========================================
- Hits        31216    31215       -1     
- Misses      25996    25998       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added feature Adds new functionality and removed feature Adds new functionality labels Jul 1, 2026
@walterbender

Copy link
Copy Markdown
Member

It would helpful to include some before and after screenshots.
And we are migrating away from platformcolor -- using css/tokens.css instead. It would be good to use the new approach in your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/javascript Changes to JS source files bug fix Fixes a bug or incorrect behavior size/XS Extra small: < 10 lines changed

Projects

Development

Successfully merging this pull request may close these issues.

Improve text contrast for selected tool items [UI/UX]

2 participants