fix: wait for stop button visibility before clicking in E2E test#7677
Open
abhnish wants to merge 1 commit into
Open
fix: wait for stop button visibility before clicking in E2E test#7677abhnish wants to merge 1 commit into
abhnish wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7677 +/- ##
=======================================
Coverage 51.94% 51.94%
=======================================
Files 169 169
Lines 56826 56826
=======================================
Hits 29519 29519
Misses 27307 27307 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
This PR has merge conflicts with Please rebase your branch: # Add upstream remote (one-time setup)
git remote add upstream https://github.com/sugarlabs/musicblocks.git
# Fetch latest master and rebase
git fetch upstream
git rebase upstream/master
# Resolve any conflicts, then:
git push --force-with-lease origin YOUR_BRANCH
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky Cypress E2E test in
main.cy.jswherecy.get("#stop").click()was called immediately after clicking play, without waiting for the stop
button to become visible.
The stop button has
display: noneby default and only appears after theprogram starts running. Adding
.should("be.visible")before.click()tells Cypress to wait until the button is visible before interacting with it,
eliminating the timing-dependent failure.
Related Issue
N/A — pre-existing test flakiness, not tied to a specific issue.
Category
Type of Change
Testing Performed
.should("be.visible")before.click().PR Checklist