fix: handle null turtle in EnsembleBlocks._blockFindTurtle#7736
Open
Jetshree wants to merge 1 commit into
Open
fix: handle null turtle in EnsembleBlocks._blockFindTurtle#7736Jetshree wants to merge 1 commit into
Jetshree wants to merge 1 commit into
Conversation
When getTargetTurtle() returns null (turtle name not found), show user error message instead of returning null without notification. Added comprehensive test coverage for _blockFindTurtle(): - Null block handling - Missing turtle name connection - Non-existent turtle name - Successful turtle lookup Fixes crash in multi-turtle ensemble compositions when target turtle not found.
Jetshree
requested review from
Ashutoshx7,
omsuneri,
pikurasa and
walterbender
as code owners
github-actions
Bot
added
bug fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7736 +/- ##
=======================================
Coverage 51.99% 51.99%
=======================================
Files 170 170
Lines 56865 56866 +1
=======================================
+ Hits 29567 29569 +2
+ Misses 27298 27297 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Looks good - having a user-facing message makes sense. Just need to wait until after string freeze to merge. |
Contributor
Author
Thanks for review : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes null pointer handling and improves error messaging in ensemble compositions.
What Changed
Testing
All 159 tests pass (6 new + 153 existing)
98.23% code coverage on EnsembleBlocks.js
Why It Matters
When users try to control an ensemble with a non-existent turtle name, the app now shows an error message instead of silently failing. This is critical for multi-turtle compositions stability.
PR Category