fix: route portamento notes through setNote path, not fast-path triggerRelease

[santhosh-7777]

PR Category

• Bug Fix
• Feature
• Performance
• Tests
• Documentation

Problem

Playing a glide block over multiple notes did not slide the pitch across the whole phrase. Instead, the first note played normally and the next notes played as separate, disconnected notes breaking issue.

fixes #7023.

Root Cause

Inside _performNotes() in js/utils/synthutils.js, there is a "fast path" added for performance that skips the normal effects setup for simple notes.

• The check that decides which notes need the full setup (_needsGraphRewire, ~line 1864) only looks at vibrato, distortion, tremolo, phaser, chorus, and neighbor effects.
• It never checks for portamento (glide).
• Because of this, every glide note takes the fast path, which always calls triggerAttackRelease and completely ignores the setNote flag.
• The correct glide logic already existed in the slow path (~lines 2043–2062), where setNote is checked and synth.setNote(notes) is called to continue the same note and bend the pitch , but glide notes never reached that code.

Fix

Added doPortamento && setNote to the _needsGraphRewire check, so glide notes go through the slow path where setNote is handled correctly.

Testing

1. Open Music Blocks, drag a glide block onto the canvas.
2. Put two note blocks inside it with different pitches (e.g. sol 4 then la 4).
3. Run the project.
4. Before the fix: two separate notes play, no slide.
5. After the fix: pitch slides smoothly from the first note into the second, no gap.
6. Added 3 Jest tests in js/utils/__tests__/synthutils.test.js (_performNotes glide/portamento setNote routing):
   • checks setNote is called (not triggerAttackRelease) when glide + setNote are both true
   • checks triggerAttackRelease still runs when setNote is false (no regression)
   • checks normal, non-glide notes still work the same as before
7. Ran the full synthutils.test.js suite locally , all 118 tests pass, nothing broke.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.83%. Comparing base (338362b) to head (9b9e98c).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7758      +/-   ##
==========================================
+ Coverage   56.80%   56.83%   +0.02%     
==========================================
  Files         172      172              
  Lines       57683    57683              
==========================================
+ Hits        32767    32784      +17     
+ Misses      24916    24899      -17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[walterbender]

@ssz2605 what do you think? LGTM