fix: guard Transport scheduling against stopped clock and stale time#7759
Draft
ssz2605 wants to merge 2 commits into
Draft
fix: guard Transport scheduling against stopped clock and stale time#7759ssz2605 wants to merge 2 commits into
ssz2605 wants to merge 2 commits into
Conversation
7a6ef44 to
60cf2f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
What does this PR do?
This PR fixes three edge cases found after the
Tone.Transportscheduling changes introduced in #7703.Fixes
Guard against stopped
Tone.TransportTone.Transport, causing scheduled callbacks to never execute.Tone.Transport.schedule(). If not, it falls back to the existingsetTimeoutscheduling path.Guard against suspended AudioContext
Tone.Transport.statereturns"started"even when the AudioContext is suspended (the frozen context time still shows "started").isClockRunninggetter that checksTone.context.state === "running"to distinguish a truly running Transport from a stuck one.Prevent scheduling in the past
These are follow-up fixes to #7703 that improve robustness without changing the scheduling improvements introduced there.