fix(tests): resolve post-merge test regressions from #7646 and #7647#7766
Merged
walterbender merged 1 commit intoJul 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7766 +/- ##
==========================================
+ Coverage 57.51% 57.91% +0.39%
==========================================
Files 173 173
Lines 57751 57758 +7
==========================================
+ Hits 33218 33449 +231
+ Misses 24533 24309 -224 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…garlabs#7647 pitchstaircase.test.js: add style:{} and playCell arg to the _playOne test to match the updated two-arg signature added by sugarlabs#7719; add replaceChildren and classList to addButton mocks in init button handlers describe so the mock does not pollute downstream assertions. musickeyboard.test.js: mock _syncLayouts in the _sortLayout ordering test so fillChromaticGaps does not expand the 3-item layout before the toEqual assertion runs.
Ashutoshx7
force-pushed
the
fix/test-regressions-7646-7647
branch
from
d005529 to
832af3c
Compare
vanshika2720
approved these changes
Jul 8, 2026
vanshika2720
left a comment
vanshika2720
left a comment
Contributor
There was a problem hiding this comment.
@Ashutoshx7 Confirmed locally. This fixes the test regression. LGTM
Member
Author
|
@walterbender fixes the regression reported by vanshika |
github-project-automation
Bot
moved this from Todo
to Done
in @MusicBlocks Issues and PRs
rakshityadav1868
pushed a commit
to rakshityadav1868/musicblocks
that referenced
this pull request
Jul 9, 2026
…garlabs#7647 (sugarlabs#7766) pitchstaircase.test.js: add style:{} and playCell arg to the _playOne test to match the updated two-arg signature added by sugarlabs#7719; add replaceChildren and classList to addButton mocks in init button handlers describe so the mock does not pollute downstream assertions. musickeyboard.test.js: mock _syncLayouts in the _sortLayout ordering test so fillChromaticGaps does not expand the 3-item layout before the toEqual assertion runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick follow-up to fix test failures that slipped into
masterafter #7646 and #7647 were merged on top of #7719.What changed
_playOnetest inpitchstaircase.test.jsto match the new_playOne(stepCell, playCell)signature.stylemock onstepCellso the background color update does not throw.replaceChildrenandclassList.contains, since later tests rely on those methods duringinit()._syncLayouts()in the_sortLayouttest inmusickeyboard.test.jsso the test stays focused on sorting only, without chromatic gap filling changing the layout.Testing
npm run lintpassesnpx prettier --check .passes