fix: replace SVG RECORDBUTTON with Material Icons ligature in toolbar#7783
Closed
ssz2605 wants to merge 1 commit into
Closed
fix: replace SVG RECORDBUTTON with Material Icons ligature in toolbar#7783ssz2605 wants to merge 1 commit into
ssz2605 wants to merge 1 commit into
Conversation
Record button used an SVG string set via innerHTML, which broke when PR 7757 converted innerHTML to textContent for security. Instead of reverting to innerHTML, move the icon to index.html as a static Material Icons ligature element, matching how Play and Stop work. - Add fiber_manual_record to #record in HTML - Remove dynamic icon creation from toolbar-ui.js - Remove unused RECORDBUTTON import from turtledefs.js - Update tests to reflect static icon
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7783 +/- ##
==========================================
- Coverage 59.00% 59.00% -0.01%
==========================================
Files 175 175
Lines 57916 57915 -1
==========================================
- Hits 34172 34171 -1
Misses 23744 23744 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Todo
to Done
in @MusicBlocks Issues and PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.