fix(i18n): fix machine converted kana from Hiragana to Katakana#7784
Merged
walterbender merged 1 commit intoJul 11, 2026
Merged
Conversation
pikurasa
commented
Jul 11, 2026
Collaborator
- Ignore editorial fixes; Ignore Kanji
- Change words that should be read as Katakana from Hiragana
* Ignore editorial fixes; Ignore Kanji * Change words that should be read as Katakana from Hiragana
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7784 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 175 175
Lines 57920 57920
=======================================
Hits 34176 34176
Misses 23744 23744 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Here is my working draft of my notes as I worked through this: There were a few different issues to resolve. This PR /mainly/ (but not perfectly) focuses on converting words that should be Katakana from Hiragana. We're assuming ~2nd grade reading level, so they will know Katakana. What I tried not to focus on, but I jotted down as I was working was:
Hope this helps... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.