fix: replace SVG RECORDBUTTON with Material Icons ligature in toolbar#7785
Closed
ssz2605 wants to merge 2 commits into
Closed
fix: replace SVG RECORDBUTTON with Material Icons ligature in toolbar#7785ssz2605 wants to merge 2 commits into
ssz2605 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7785 +/- ##
==========================================
- Coverage 59.00% 59.00% -0.01%
==========================================
Files 175 175
Lines 57916 57911 -5
==========================================
- Hits 34172 34169 -3
+ Misses 23744 23742 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Record button used an SVG string set via innerHTML, which broke when PR 7757 converted innerHTML to textContent for security. Instead of reverting to innerHTML, move the icon to index.html as a static Material Icons ligature element, matching how Play and Stop work. - Add fiber_manual_record to #record in HTML - Remove dynamic icon creation from toolbar-ui.js - Refactor recorder.js to use CSS class on #record instead of targeting the now-removed rec_inside SVG element - Add #record.recording CSS for blink animation and red color - Remove dead RECORDBUTTON SVG constant from artwork.js - Remove unused RECORDBUTTON imports from toolbar-ui.js and turtledefs.js - Update tests to reflect static icon and class-based recording state
8993152 to
c393edb
Compare
c393edb to
0c205d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #7757 replaced innerHTML with textContent for security, which broke
the Record button , RECORDBUTTON is an SVG string, not a Material Icons
ligature, so textContent cannot render it. PR #7782 reverted to innerHTML
as a temporary fix, but left the original problems unsolved:
the SVG. If anyone changes the SVG, recording breaks again.
This PR fixes all of them:
PR Category