fix: broken tie in Rainbow Connection#7790
Open
walterbender wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7790 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 175 175
Lines 57916 57916
=======================================
Hits 34172 34172
Misses 23744 23744 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
force-pushed
the
fix/rainbow-connection
branch
from
ef716ab to
e1ef252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error triggered in a tie in measures 17-19 in Rainbow Connection. Not sure why the tie triggered the failure, as the two notes being tied were both quarter notes of Do 5. But removing the tie and the second quarter note and changing the value of the first note to half note fixes the problem. Merits further investigation, but now the example project plays w/o throwing an error.