Skip to content

fix: hover help for grid piemenu#7796

Merged
walterbender merged 3 commits into
masterfrom
fix/grid-hover-help
Jul 13, 2026
Merged

fix: hover help for grid piemenu#7796
walterbender merged 3 commits into
masterfrom
fix/grid-hover-help

Conversation

@walterbender

Copy link
Copy Markdown
Member

There are two problems with hover help in the grid pie menu:

(1) the strings were not being translated; and
(2) the strings did not match the strings in ExtraBlocks.js so even if they were translated, they would not appear in the PO files.

This PR addresses both issues:
(1) the hover text is now wrapped in _() so it is sent through the translation system; and
(2) the list of labels now matches the strings in ExtraBlocks.js so that they are properly translated.

Before:

image

After:

image

Testing: Tested in both EN and JA to ensure hover text displays properly and grids are rendered properly.

@walterbender walterbender added bug fix Fixes a bug or incorrect behavior area/i18n Changes to localization files labels Jul 12, 2026
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.27%. Comparing base (8924384) to head (91e1b44).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
js/piemenus.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7796   +/-   ##
=======================================
  Coverage   59.27%   59.27%           
=======================================
  Files         176      176           
  Lines       57975    57975           
=======================================
  Hits        34365    34365           
  Misses      23610    23610           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot force-pushed the fix/grid-hover-help branch from 97412a1 to f421ac4 Compare July 12, 2026 16:59
@walterbender

Copy link
Copy Markdown
Member Author

@vanshika2720 please review

Comment thread js/piemenus.js
];

// Use the same strings as found in ExtraBlocks.js for i18n purposes.
gridLabels = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterbender Verified locally. The hover help is now translated correctly, and the labels match those in ExtrasBlocks.js as expected but there is a small typo ,actually the file name is ExtrasBlocks.js.

@github-actions github-actions Bot force-pushed the fix/grid-hover-help branch from f421ac4 to 78d2dd3 Compare July 13, 2026 11:03
@walterbender walterbender merged commit 987572e into master Jul 13, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n Changes to localization files bug fix Fixes a bug or incorrect behavior

Projects

Development

Successfully merging this pull request may close these issues.

2 participants