fix: hover help for grid piemenu#7796
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7796 +/- ##
=======================================
Coverage 59.27% 59.27%
=======================================
Files 176 176
Lines 57975 57975
=======================================
Hits 34365 34365
Misses 23610 23610 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
97412a1 to
f421ac4
Compare
Member
Author
|
@vanshika2720 please review |
1 task
| ]; | ||
|
|
||
| // Use the same strings as found in ExtraBlocks.js for i18n purposes. | ||
| gridLabels = [ |
Contributor
There was a problem hiding this comment.
@walterbender Verified locally. The hover help is now translated correctly, and the labels match those in ExtrasBlocks.js as expected but there is a small typo ,actually the file name is ExtrasBlocks.js.
f421ac4 to
78d2dd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two problems with hover help in the grid pie menu:
(1) the strings were not being translated; and
(2) the strings did not match the strings in ExtraBlocks.js so even if they were translated, they would not appear in the PO files.
This PR addresses both issues:
(1) the hover text is now wrapped in _() so it is sent through the translation system; and
(2) the list of labels now matches the strings in ExtraBlocks.js so that they are properly translated.
Before:
After:
Testing: Tested in both EN and JA to ensure hover text displays properly and grids are rendered properly.