This repository was archived by the owner on Feb 13, 2026. It is now read-only.
add model level validation for uniqueness of step in a given workflow and version#283
Merged
add model level validation for uniqueness of step in a given workflow and version#283
Conversation
peetucket
force-pushed
the
282-dupe-validation
branch
from
c2e6b64 to
4300ef8
Compare
peetucket
commented
Nov 15, 2019
| let!(:item2) do | ||
| FactoryBot.create(:workflow_step, | ||
| repository: 'sdr', | ||
| process: 'publish', |
Contributor
Author
There was a problem hiding this comment.
necessary for tests to continue to work with our new validation that prevents dupe steps from being added ... doesn't need to be "publish" but needs to be different than :item1 and :item3
peetucket
commented
Nov 15, 2019
|
|
||
| let!(:item3) do | ||
| FactoryBot.create(:workflow_step) | ||
| FactoryBot.create(:workflow_step, process: 'shelve') |
Contributor
Author
There was a problem hiding this comment.
necessary for tests to continue to work with our new validation that prevents dupe steps from being added ... doesn't need to be "shelve" but needs to be different than :item1 and :item2
mjgiarlo
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this change made?
fixes #282
note: we should eventually follow this up with the work in #40, but this is a good first step that can be implemented right now
Was the documentation (API, README, DevOpsDocs, wiki, consul, etc.) updated?