[HOLD] Edit project tag from the show page

[jcoyne]

Blocked by sul-dlss/dor-services-app#3581

Why was this change made? 🤔

Fixes #3103

How was this change tested? 🤨

⚡ ⚠ If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡

⚡ ⚠ If this change updates the Argo UI, run all integration tests that use Argo and create a PR on that repo to fix anything this change breaks. ⚡

[andrewjbtw]

I tested this on stage with a collection and an item. I'm able to add a Project tag via the Project tag in-line edit but I can't delete it. When I save a blank cell the tag disappears from the Project row but remains in the "tags" box and then returns to the Project row when I reindex.

If I remove the Project tag from the tags modal, then it really does get deleted.

[jcoyne]

@justinlittman I think this problem is because partOfProject is not nillable: https://github.com/sul-dlss/cocina-models/blob/main/openapi.yml#L177-L180

Relevant HB:
https://app.honeybadger.io/projects/49894/faults/84227275

[justinlittman]

sul-dlss/cocina-models#321 for making partOfProject nillable.

[andrewjbtw]

Should this be closed now?

[jcoyne]

@andrewjbtw I guess this is a question for you (or @astridu). Do the users want to conceptualize "Project(s)" as a tag or do we want to make "Project(s)" a separate property. I think it's confusing that we're treating it both ways at present.

[andrewjbtw]

Closing this in favor of opening a new ticket later if we decide to change our approach to editing tags.

[andrewjbtw]

Sorry, I meant to close the issue not the PR. But I think the PR can be closed too, I'm just not sure if I'm supposed to do that.