Open
Conversation
Before this change the dtsi task depended on the source `.dtsi.erb` files. This meant that it didn't check whether the compiled bare `.dtsi` were up-to-date, and never recompiled them. Running the default task still compiled them however due the `.dot` outputs having a transitive dependency on the minified `.dtsi` files. With this fix, running `./rake dtsi` rebuilds the `.dtsi` files (really just `keymap.dtsi`).
sunaku
force-pushed
the
main
branch
3 times, most recently
from
7e5efd3 to
7d8c007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the dtsi task depended on the source
.dtsi.erbfiles. This meant that it didn't check whether the compiled bare.dtsiwere up-to-date, and never recompiled them. Running the default task still compiled them however due the.dotoutputs having a transitive dependency on the minified.dtsifiles.With this fix, running
./rake dtsirebuilds the.dtsifiles (really justkeymap.dtsi).