Open
Conversation
ed8e25a to
ac1666f
Compare
samaloney
commented
Apr 16, 2026
Member
Author
|
Since these should not change maybe use broader cache key Can also maybe cache the same data for the doc builds? |
Cadair
reviewed
Apr 17, 2026
| envs: | | ||
| - linux: py314 | ||
| cache-path: $HOME/sunpy/data_manager | ||
| cache-key: sunpy-data-linux-${{ github.ref }} |
Member
There was a problem hiding this comment.
Is there not a github context var for OS name?
Member
Author
There was a problem hiding this comment.
Maybe I could use runner.os and have single cache block for the all the envs
Member
Author
There was a problem hiding this comment.
Nope doesn't have access to the runner info at that stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Use openastronomy GHA templates caching features to cache the CHIANTI files.
So what should ideally happen with this PR is that once it's merge to main it will run and generate the cache entries for each os with keys ending in
refs/heads/maine.g.sunpy-data-linux-refs/heads/mainthen any subsequent run will restore the cache from these keysAI Assistance Disclosure
AI tools were used for: