Skip to content

fixes for Master 27 under Linux#4382

Open
wschadow wants to merge 14 commits intosupermerill:master_27from
Caribou3d:master_27
Open

fixes for Master 27 under Linux#4382
wschadow wants to merge 14 commits intosupermerill:master_27from
Caribou3d:master_27

Conversation

@wschadow
Copy link
Copy Markdown

The fixes (typos, paths to include files, type corrections) make it possible to compile and run under Linux. In additon I've added profiles and .mo files.

@wschadow wschadow requested a review from supermerill as a code owner July 20, 2024 08:21
@wschadow
Copy link
Copy Markdown
Author

With the last changes it is possible to build the code under Linux (tested Debian Buster), Win (tested 10), and macOS (tested Catalina 10.14) now. The Slicer is working in "general", but has not been tested in depth.

@supermerill
Copy link
Copy Markdown
Owner

Thanks

I edited a new commit, as many elements shouldn't be added (like profiles)
I also changed the #include "../XX" by #include "libslic3r/XXX, as it's safer if the file move again.
I reuse your macos build file, and updated the linux one to include -wrt

little notes:

  • "CMP0135" is set two times in deps/cmakefiles
  • sla/concurency is deleted, and sla/indexedmesh is now renamed AABBmesh

questions:
why revert libtiff to 4.1 for apple?

@wschadow
Copy link
Copy Markdown
Author

wschadow commented Aug 1, 2024

Thanks for you notes.

Using libtiff 4.6 under masOS does not work. It cannot find CMATH::cmath in that case.

@supermerill
Copy link
Copy Markdown
Owner

Using libtiff 4.6 under masOS does not work. It cannot find CMATH::cmath in that case.

right.
Prusa remove libtiff in 2.8, so i'll try by removing it rn.

@wschadow
Copy link
Copy Markdown
Author

wschadow commented Aug 2, 2024

yes, there was a parameter missing as well. Prusa commented on my pull request #12382
that libtiff will be be removed. I think it is not explicitly used and just a compile option for wxwidgets. It may be removed easily.

@wschadow
Copy link
Copy Markdown
Author

wschadow commented Aug 2, 2024

yes, it's easy to remove 49e646d5c1ef6c1b854a87ab6e559b055a8d24ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants