proper usage of NanoSVG#4574
Open
schiele wants to merge 1 commit intosupermerill:devfrom
Open
Conversation
The old code materialized the library code into the slicer binary instead of linking the library itself. This does complicate the structure and since I didn't really see the point I changed this to just link the library.
Owner
|
It's still compiling on windows and mac? |
Author
Honestly, I have no machine at hand where I could test this. Technically I would expect so since I moved this from a very exotic way of implementing this into the standard CMake approach of integrating a library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code materialized the library code into the slicer binary instead of linking the library itself. This does complicate the structure and since I didn't really see the point I changed this to just link the library.