API Changes to Boost and CGAL#4635
Open
seanmccully wants to merge 1 commit intosupermerill:master_27from
Open
Conversation
- Boost Process V2 API changes - Updates CMake for boost linking - CGAL property_map accessors
Owner
|
tried to compile on windows but I had an error: |
Author
Apologies I sort of realized after I opened this I probably should have given this (build) on Windows/Mac. I will look at it again and update you. |
jacobcxdev
added a commit
to jacobcxdev/BambuStudio
that referenced
this pull request
Aug 4, 2025
Updated dependencies, added CGALCompat from supermerill/SuperSlicer#4635.
|
Trying this PR on FreeBSD, with CGAL 5.6.2, I don't have CGAL/AABB_traits_3.h, only CGAL/AABB_traits.h (and CGAL/Minkowski_sum_2/AABB_traits_2.h and CGAL/Surface_mesh_segmentation/internal/AABB_traits.h) so I think you need to check for the header in CMake rather than assume presence based on version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Boost and CGAL API changes in the recent builds for both projects. It attempts to add a compatibility layer between the old API and New API to support the minimal difference in supporting both versions.
The goal being to fix the build issues on Linux when using system libraries for distributions with rolling releases like Arch-Linux
.