Skip to content

Prevent segfault on linux a few seconds after start#4768

Open
tedvdb wants to merge 2 commits intosupermerill:master_27from
tedvdb:master_27
Open

Prevent segfault on linux a few seconds after start#4768
tedvdb wants to merge 2 commits intosupermerill:master_27from
tedvdb:master_27

Conversation

@tedvdb
Copy link
Copy Markdown

@tedvdb tedvdb commented Feb 6, 2026

Made a debug build, attached gdb and found this issue in semver.c.

I couldn't get i to crash anymore.

@tedvdb tedvdb requested a review from supermerill as a code owner February 6, 2026 10:43
@supermerill
Copy link
Copy Markdown
Owner

i don't really understand.
On linux, assert still create exception even when compiled on release mode?

@tedvdb
Copy link
Copy Markdown
Author

tedvdb commented Mar 10, 2026

i don't really understand. On linux, assert still create exception even when compiled on release mode?

No the real fix is in src/semver/semver.c.

The changes in src/libslic3r/GCode.cpp were necessary to make a debug build possible. This is cause by m_loop_vase_mode only being available if it's a debug build.

@supermerill
Copy link
Copy Markdown
Owner

understood. I guess the fix is the

      if (res.counters == NULL)
          res.counter_size = 0;

at the end, as it was (without it) the only way to have a counter_size !=0 while counters are null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants