superset-sh
diff --git a/‎apps/desktop/src/lib/trpc/routers/workspaces/utils/git.ts‎
Lines changed: 2 additions & 1 deletion b/‎apps/desktop/src/lib/trpc/routers/workspaces/utils/git.ts‎
Lines changed: 2 additions & 1 deletion
diff --git a/‎apps/desktop/src/main/lib/notifications/notification-manager.test.ts‎
Lines changed: 2 additions & 2 deletions b/‎apps/desktop/src/main/lib/notifications/notification-manager.test.ts‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/ChatInputFooter/ChatInputFooter.tsx‎
Lines changed: 1 addition & 22 deletions b/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/ChatInputFooter/ChatInputFooter.tsx‎
Lines changed: 1 addition & 22 deletions
diff --git a/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/ChatInputFooter/components/ChatComposerControls/ChatComposerControls.tsx‎
Lines changed: 1 addition & 3 deletions b/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/ChatInputFooter/components/ChatComposerControls/ChatComposerControls.tsx‎
Lines changed: 1 addition & 3 deletions
diff --git a/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/ChatInputFooter/components/ChatShortcuts/ChatShortcuts.tsx‎
Lines changed: 1 addition & 14 deletions b/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/ChatInputFooter/components/ChatShortcuts/ChatShortcuts.tsx‎
Lines changed: 1 addition & 14 deletions
diff --git a/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/IssueLinkCommand/IssueLinkCommand.tsx‎
Lines changed: 88 additions & 110 deletions b/‎apps/desktop/src/renderer/components/Chat/ChatInterface/components/IssueLinkCommand/IssueLinkCommand.tsx‎
Lines changed: 88 additions & 110 deletions
@@ -1791,7 +1791,8 @@ export async function createWorktreeFromPr({
 				{ cwd: worktreePath, timeout: 120_000 },
 			);
 		} catch (ghError) {
-			const ghMsg = ghError instanceof Error ? ghError.message : String(ghError);
+			const ghMsg =
+				ghError instanceof Error ? ghError.message : String(ghError);
 			// `gh pr checkout` can fail with "is not a branch" when the branch name
 			// contains '/' (e.g. "user/feature-branch"). Git has trouble resolving
 			// "origin/user/feature-branch" as a tracking ref inside a worktree.
 
@@ -297,8 +297,8 @@ describe("NotificationManager", () => {
 
 			expect(createNotification).toHaveBeenCalledWith(
 				expect.objectContaining({
-					title: "Input Needed — Test Workspace",
-					body: '"Test Title" needs your attention',
+					title: "Awaiting Response — Test Workspace",
+					body: '"Test Title" is waiting for your reply',
 				}),
 			);
 		});
 
@@ -14,7 +14,6 @@ import { useFocusPromptOnPane } from "renderer/components/Chat/ChatInterface/hoo
 import { useHotkeyDisplay } from "renderer/hotkeys";
 import type { SlashCommand } from "../../hooks/useSlashCommands";
 import type { ModelOption, PermissionMode } from "../../types";
-import { IssueLinkCommand } from "../IssueLinkCommand";
 import { TiptapPromptEditor } from "../TiptapPromptEditor";
 import { ChatComposerControls } from "./components/ChatComposerControls";
 import { ChatInputDropZone } from "./components/ChatInputDropZone";
@@ -100,23 +99,12 @@ export function ChatInputFooter({
 		}
 	}, [pendingQuestion, textInput]);
 
-	const [issueLinkOpen, setIssueLinkOpen] = useState(false);
 	const [linkedIssues, setLinkedIssues] = useState<LinkedIssue[]>([]);
 	const inputRootRef = useRef<HTMLDivElement>(null);
 	const errorMessage = getErrorMessage(error);
 	const focusShortcutText = useHotkeyDisplay("FOCUS_CHAT_INPUT").text;
 	const showFocusHint = focusShortcutText !== "Unassigned";
 
-	const addLinkedIssue = useCallback(
-		(slug: string, title: string, taskId: string | undefined, url?: string) => {
-			setLinkedIssues((prev) => {
-				if (prev.some((issue) => issue.slug === slug)) return prev;
-				return [...prev, { slug, title, taskId, url }];
-			});
-		},
-		[],
-	);
-
 	const removeLinkedIssue = useCallback((slug: string) => {
 		setLinkedIssues((prev) => prev.filter((issue) => issue.slug !== slug));
 	}, []);
@@ -176,15 +164,7 @@ export function ChatInputFooter({
 								maxFileSize={10 * 1024 * 1024}
 								globalDrop
 							>
-								<ChatShortcuts
-									isFocused={isFocused}
-									setIssueLinkOpen={setIssueLinkOpen}
-								/>
-								<IssueLinkCommand
-									open={issueLinkOpen}
-									onOpenChange={setIssueLinkOpen}
-									onSelect={addLinkedIssue}
-								/>
+								<ChatShortcuts isFocused={isFocused} />
 								<FileDropOverlay visible={dragType === "files"} />
 								<PromptInputAttachments>
 									{renderAttachment ??
@@ -217,7 +197,6 @@ export function ChatInputFooter({
 									submitStatus={submitStatus}
 									submitDisabled={submitDisabled}
 									onStop={onStop}
-									onLinkIssue={() => setIssueLinkOpen(true)}
 								/>
 							</PromptInput>
 						</div>
 
@@ -30,7 +30,6 @@ interface ChatComposerControlsProps {
 	submitStatus?: ChatStatus;
 	submitDisabled?: boolean;
 	onStop: (event: React.MouseEvent) => void;
-	onLinkIssue: () => void;
 }
 
 export function ChatComposerControls({
@@ -47,7 +46,6 @@ export function ChatComposerControls({
 	submitStatus,
 	submitDisabled,
 	onStop,
-	onLinkIssue,
 }: ChatComposerControlsProps) {
 	return (
 		<PromptInputFooter>
@@ -70,7 +68,7 @@ export function ChatComposerControls({
 				/>
 			</PromptInputTools>
 			<div className="flex items-center gap-2">
-				<PlusMenu onLinkIssue={onLinkIssue} />
+				<PlusMenu />
 				<PromptInputSubmit
 					className="size-[23px] rounded-full border border-transparent bg-foreground/10 shadow-none p-[5px] hover:bg-foreground/20"
 					status={submitStatus}
 
@@ -2,18 +2,13 @@ import {
 	usePromptInputAttachments,
 	usePromptInputController,
 } from "@superset/ui/ai-elements/prompt-input";
-import type React from "react";
 import { useHotkey } from "renderer/hotkeys";
 
 interface ChatShortcutsProps {
 	isFocused: boolean;
-	setIssueLinkOpen: React.Dispatch<React.SetStateAction<boolean>>;
 }
 
-export function ChatShortcuts({
-	isFocused,
-	setIssueLinkOpen,
-}: ChatShortcutsProps) {
+export function ChatShortcuts({ isFocused }: ChatShortcutsProps) {
 	const attachments = usePromptInputAttachments();
 	const { textInput } = usePromptInputController();
 
@@ -25,14 +20,6 @@ export function ChatShortcuts({
 		{ enabled: isFocused, preventDefault: true },
 	);
 
-	useHotkey(
-		"CHAT_LINK_ISSUE",
-		() => {
-			setIssueLinkOpen((prev) => !prev);
-		},
-		{ enabled: isFocused, preventDefault: true },
-	);
-
 	useHotkey(
 		"FOCUS_CHAT_INPUT",
 		() => {
 
@@ -1,17 +1,16 @@
 import {
 	Command,
-	CommandDialog,
 	CommandEmpty,
 	CommandGroup,
 	CommandInput,
 	CommandItem,
 	CommandList,
 } from "@superset/ui/command";
-import { Popover, PopoverAnchor, PopoverContent } from "@superset/ui/popover";
+import { Popover, PopoverContent, PopoverTrigger } from "@superset/ui/popover";
+import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip";
 import { useLiveQuery } from "@tanstack/react-db";
 import Fuse from "fuse.js";
-import type React from "react";
-import type { RefObject } from "react";
+import type { ReactNode } from "react";
 import { useMemo, useState } from "react";
 import {
 	StatusIcon,
@@ -21,22 +20,23 @@ import { useCollections } from "renderer/routes/_authenticated/providers/Collect
 
 const MAX_RESULTS = 20;
 
-type IssueLinkCommandProps = {
-	open: boolean;
-	onOpenChange: (open: boolean) => void;
+interface IssueLinkCommandProps {
+	children: ReactNode;
+	tooltipLabel: string;
 	onSelect: (
 		slug: string,
 		title: string,
 		taskId: string | undefined,
 		url?: string,
 	) => void;
-} & (
-	| { variant?: "dialog" }
-	| { variant: "popover"; anchorRef: RefObject<HTMLElement | null> }
-);
+}
 
-export function IssueLinkCommand(props: IssueLinkCommandProps) {
-	const { open, onOpenChange, onSelect } = props;
+export function IssueLinkCommand({
+	children,
+	tooltipLabel,
+	onSelect,
+}: IssueLinkCommandProps) {
+	const [open, setOpen] = useState(false);
 	const [searchQuery, setSearchQuery] = useState("");
 	const collections = useCollections();
 
@@ -108,115 +108,93 @@ export function IssueLinkCommand(props: IssueLinkCommandProps) {
 			.map((r) => r.item);
 	}, [allTasks, searchQuery, taskFuse]);
 
-	const handleClose = () => {
-		setSearchQuery("");
-		onOpenChange(false);
-	};
-
 	const handleSelect = (
 		slug: string,
 		title: string,
 		taskId: string | undefined,
 		url?: string,
 	) => {
 		onSelect(slug, title, taskId, url);
-		handleClose();
+		setSearchQuery("");
+		setOpen(false);
 	};
 
-	const issueListContent = (
-		<>
-			<CommandInput
-				placeholder="Search issues..."
-				value={searchQuery}
-				onValueChange={setSearchQuery}
-			/>
-			<CommandList
-				className={props.variant === "popover" ? "max-h-[280px]" : undefined}
-			>
-				{filteredTasks.length === 0 && (
-					<CommandEmpty>No issues found.</CommandEmpty>
-				)}
-				{filteredTasks.length > 0 && (
-					<CommandGroup heading={searchQuery ? "Results" : "Recent issues"}>
-						{filteredTasks.map((task) => {
-							const status = task.statusId
-								? statusMap.get(task.statusId)
-								: undefined;
-							return (
-								<CommandItem
-									key={task.id}
-									value={task.slug}
-									onSelect={() =>
-										handleSelect(
-											task.slug,
-											task.title,
-											task.id,
-											task.externalUrl ?? undefined,
-										)
-									}
-									className="group"
-								>
-									{status ? (
-										<StatusIcon
-											type={status.type}
-											color={status.color}
-											progress={status.progressPercent ?? undefined}
-										/>
-									) : (
-										<span className="size-3.5 shrink-0 rounded-full border border-muted-foreground/40" />
-									)}
-									<span className="max-w-24 shrink-0 truncate font-mono text-xs text-muted-foreground">
-										{task.slug}
-									</span>
-									<span className="min-w-0 flex-1 truncate text-xs">
-										{task.title}
-									</span>
-									<span className="shrink-0 hidden text-xs text-muted-foreground group-data-[selected=true]:inline">
-										Link ↵
-									</span>
-								</CommandItem>
-							);
-						})}
-					</CommandGroup>
-				)}
-			</CommandList>
-		</>
-	);
-
-	if (props.variant === "popover") {
-		return (
-			<Popover open={open}>
-				<PopoverAnchor
-					virtualRef={props.anchorRef as React.RefObject<Element>}
-				/>
-				<PopoverContent
-					className="w-80 p-0"
-					align="start"
-					side="bottom"
-					onWheel={(event) => event.stopPropagation()}
-					onPointerDownOutside={handleClose}
-					onEscapeKeyDown={handleClose}
-					onFocusOutside={(e) => e.preventDefault()}
-				>
-					<Command shouldFilter={false}>{issueListContent}</Command>
-				</PopoverContent>
-			</Popover>
-		);
-	}
-
 	return (
-		<CommandDialog
+		<Popover
 			open={open}
-			onOpenChange={(nextOpen) => {
-				if (!nextOpen) setSearchQuery("");
-				onOpenChange(nextOpen);
+			onOpenChange={(next) => {
+				if (!next) setSearchQuery("");
+				setOpen(next);
 			}}
-			modal
-			title="Link issue"
-			description="Search for an issue to link"
-			showCloseButton={false}
 		>
-			{issueListContent}
-		</CommandDialog>
+			<Tooltip>
+				<PopoverTrigger asChild>
+					<TooltipTrigger asChild>{children}</TooltipTrigger>
+				</PopoverTrigger>
+				<TooltipContent side="bottom">{tooltipLabel}</TooltipContent>
+			</Tooltip>
+			<PopoverContent
+				className="w-80 p-0"
+				align="start"
+				side="bottom"
+				onWheel={(event) => event.stopPropagation()}
+			>
+				<Command shouldFilter={false}>
+					<CommandInput
+						placeholder="Search issues..."
+						value={searchQuery}
+						onValueChange={setSearchQuery}
+					/>
+					<CommandList className="max-h-[280px]">
+						{filteredTasks.length === 0 && (
+							<CommandEmpty>No issues found.</CommandEmpty>
+						)}
+						{filteredTasks.length > 0 && (
+							<CommandGroup heading={searchQuery ? "Results" : "Recent issues"}>
+								{filteredTasks.map((task) => {
+									const status = task.statusId
+										? statusMap.get(task.statusId)
+										: undefined;
+									return (
+										<CommandItem
+											key={task.id}
+											value={task.slug}
+											onSelect={() =>
+												handleSelect(
+													task.slug,
+													task.title,
+													task.id,
+													task.externalUrl ?? undefined,
+												)
+											}
+											className="group"
+										>
+											{status ? (
+												<StatusIcon
+													type={status.type}
+													color={status.color}
+													progress={status.progressPercent ?? undefined}
+												/>
+											) : (
+												<span className="size-3.5 shrink-0 rounded-full border border-muted-foreground/40" />
+											)}
+											<span className="max-w-24 shrink-0 truncate font-mono text-xs text-muted-foreground">
+												{task.slug}
+											</span>
+											<span className="min-w-0 flex-1 truncate text-xs">
+												{task.title}
+											</span>
+											<span className="shrink-0 hidden text-xs text-muted-foreground group-data-[selected=true]:inline">
+												Link ↵
+											</span>
+										</CommandItem>
+									);
+								})}
+							</CommandGroup>
+						)}
+					</CommandList>
+				</Command>
+			</PopoverContent>
+		</Popover>
 	);
 }