Skip to content

fix(desktop): keep cloud workspaces visible when Cloud dropdown is collapsed - #6803

Open
AviPeltz wants to merge 3 commits into
mainfrom
cloud-dropdown-collapse
Open

fix(desktop): keep cloud workspaces visible when Cloud dropdown is collapsed#6803
AviPeltz wants to merge 3 commits into
mainfrom
cloud-dropdown-collapse

Conversation

@AviPeltz

@AviPeltz AviPeltz commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Collapsing the "Cloud" section's dropdown header used to hide the entire cloud workspace list. Now the workspace rows always stay visible; only the header's chevron reflects the collapsed/expanded state.

Test plan

  • biome check on the changed file
  • tsc --noEmit shows no new errors from this file
  • Manually collapse the Cloud section header in the desktop app and confirm workspace rows stay visible

https://claude.ai/code/session_01Env8JHRqvfTtPtQjFt5TBT


Summary by cubic

Restores standard collapse behavior for the Cloud section. Collapsing the Cloud dropdown now hides its workspace rows; only a collapsed sidebar rail forces the compact icon layout. This removes the half-working states from prior changes and aligns Cloud with Pinned and Sessions.

  • Sidebar rail collapsed: show compact icon rows. Rail expanded: show full rows unless the Cloud section is collapsed.
  • Cloud section collapsed: hide rows. Expanded: show rows in the current rail mode.
  • No changes to ordering, pinning, or hover.

Written for commit e351031. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Cloud workspace entries remain visible when the sidebar is expanded.
    • Collapsing the Cloud section hides its workspace entries while keeping the Cloud header visible.
    • Workspace rows use compact icons when the sidebar is collapsed.
    • The divider now appears only when the sidebar is in rail mode.
    • Improved consistency across sidebar and Cloud section collapse states.

…s collapsed

Collapsing the Cloud section header used to hide the whole workspace
list; now the rows stay visible and only the header's chevron cue
reflects the collapsed state.

Claude-Session: https://claude.ai/code/session_01Env8JHRqvfTtPtQjFt5TBT
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a1a0299f-828b-46b4-bb1e-cd5bce21c440

📥 Commits

Reviewing files that changed from the base of the PR and between 88df484 and e351031.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarCloudSection/DashboardSidebarCloudSection.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The cloud sidebar now separates Cloud section collapse from sidebar rail collapse. Cloud section collapse hides workspace rows but keeps the Cloud header. Compact rows and the divider appear only when the sidebar rail is collapsed.

Changes

Cloud sidebar

Layer / File(s) Summary
Render cloud workspace rows by collapse state
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarCloudSection/DashboardSidebarCloudSection.tsx
Cloud section collapse hides workspace rows and preserves the Cloud header. Sidebar rail collapse renders compact workspace rows and the divider. Expanded states render the Cloud header and workspace rows.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to e3510

This is a localized change to Cloud sidebar collapse behavior, with normal static checks reported as passing. No actionable merge-blocking risk remains.

Suggested reviewers: saddlepaddle

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims collapsed Cloud workspaces remain visible, but the changeset hides those rows when the Cloud section is collapsed. Update the title to describe the restored hide-on-collapse behavior for Cloud workspace rows.
Description check ⚠️ Warning The description includes summary and test plan sections, but it contains conflicting behavior claims and omits the required checklist section. Align the description with the actual behavior, retain one consistent summary, and add the repository checklist.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cloud-dropdown-collapse

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…apse

The prior commit always rendered full workspace rows regardless of the
section's collapsed flag, so the chevron showed a collapsed cue but
nothing visually changed on click. Collapsing now switches to the
compact icon form (same as the sidebar-rail-collapsed view) instead of
doing nothing, while still never fully hiding a workspace.

Claude-Session: https://claude.ai/code/session_01Env8JHRqvfTtPtQjFt5TBT
Both of the compact/always-show variants tried here left the section's
own collapse toggle either dead or half-working. Restore the plain
hide-on-collapse behavior every other section already uses; only the
sidebar rail collapsing still forces the compact icon form.

Claude-Session: https://claude.ai/code/session_01Env8JHRqvfTtPtQjFt5TBT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant