feat(cli/sdk/mcp): expose per-launch agent models - #6805
Open
Shravankb301 wants to merge 1 commit into
Open
Conversation
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--model <id>tosuperset agents createandsuperset workspaces createmodelandeffortinputs in MCP agent and workspace launch toolsWhy
The host service has supported per-launch model selection since #5248, using
the shared per-agent model registry to translate a model ID into the correct
flag or environment variable. Desktop can already use that path, but CLI, SDK,
and MCP callers cannot.
This change exposes the existing host behavior without duplicating model maps
or changing launch semantics. Omitting
modelstill delegates to the agent'sconfigured default.
This is a focused first slice of #5202. Agent-config CRUD and arbitrary
command/environment overrides remain out of scope.
CLI surface
workspaces create --modelrequires--agent, matching the existing--effortcontract.Testing
bun test packages/cli/src/commands/agents/create/command.test.ts packages/cli/src/commands/workspaces/create/command.test.ts— 9 passedbun run typecheck— 37/37 tasks passedbun run lint— 6,189 files checked, no fixesbun run --filter @superset/cli build— passedbun run --filter @superset/sdk build— passed--modelon both launch commandsThe full
bun run testgate reached the desktop suite with 2,798 passing andone unrelated environment-sensitive failure in
getProcessEnvWithShellPath applies shell PATH: this machine adds/usr/local/sbinto the returned macOS process path, while the existing testexpects exact equality with the login-shell path. The same focused test fails
in isolation, and none of this PR's files touch shell environment handling.
Related issue
Progresses #5202.
Summary by cubic
Expose per-launch agent model selection in
@superset/cli,@superset/sdk, and@superset/mcpso callers can choose a model per run. Previously only the host/Desktop path supported per-launch models; other surfaces always used the agent default. Omitting model still uses the agent’s default. Progresses #5202.superset agents createandsuperset workspaces create; require--agentwhen using--model; forward to host; tests and help updated.modeltoagents.createandWorkspaceAgentLaunch; forward to host; docs andapi.mdupdated; no breaking changes.model(and exposeeffort) inagents_createandworkspaces_createtools; schema and docs updated.Written for commit 923fc25. Summary will update on new commits.