Skip to content

feat(desktop): device-first Workspaces page — device on rows and title, creator filter, menu/typing perf #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AviPeltz wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(desktop): device-first Workspaces page — device on rows and title, creator filter, menu/typing perf #6901

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97dbaa8
feat(desktop): restore the device item on Workspaces list rows
AviPeltz Aug 26, 2026
918146b
feat(desktop): device-first header for the Workspaces page
AviPeltz Aug 26, 2026
06438d9
feat(desktop): Created-by filter and header polish on the Workspaces …
AviPeltz Aug 26, 2026
e5bed62
feat(desktop): drop the archived toolbar dropdown, unring the search …
AviPeltz Aug 27, 2026
78ce0c4
perf(desktop): fix laggy Workspaces filter menus, project icon in tri…
AviPeltz Aug 27, 2026
7693e5e
perf(desktop): stop Workspaces search typing from janking on URL sync
AviPeltz Aug 27, 2026
058a01c
feat(desktop): let the Workspaces page compact for narrow panes
AviPeltz Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .../renderer/routes/_authenticated/_dashboard/components/WorkItemsSearch/WorkItemsSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ interface WorkItemsSearchProps {
placeholder: string;
label: string;
className?: string;
/** Extends the positioning wrapper (the icon anchors to it), not the input. */
containerClassName?: string;
}

export function WorkItemsSearch({
Expand All @@ -18,6 +20,7 @@ export function WorkItemsSearch({
placeholder,
label,
className,
containerClassName,
}: WorkItemsSearchProps) {
const inputRef = useRef<HTMLInputElement>(null);

Expand All @@ -31,7 +34,9 @@ export function WorkItemsSearch({
);

return (
<div className="relative w-full @4xl:w-56 @6xl:w-64">
<div
className={cn("relative w-full @4xl:w-56 @6xl:w-64", containerClassName)}
>
<HiOutlineMagnifyingGlass className="pointer-events-none absolute left-3 top-1/2 size-4 -translate-y-1/2 text-muted-foreground" />
<Input
ref={inputRef}
Expand Down
7 changes: 5 additions & 2 deletions ...s/components/V2WorkspacesBoard/components/V2WorkspacesBoardCard/V2WorkspacesBoardCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Badge } from "@superset/ui/badge";
import { cn } from "@superset/ui/utils";
import { memo } from "react";
import { LuGitBranch, LuLaptop, LuMonitor } from "react-icons/lu";
import { V2WorkspaceContextMenu } from "renderer/routes/_authenticated/_dashboard/v2-workspaces/components/V2WorkspaceContextMenu";
import { WorkspaceChecksDot } from "renderer/routes/_authenticated/_dashboard/v2-workspaces/components/WorkspaceChecksDot";
Expand All @@ -12,7 +13,9 @@ interface V2WorkspacesBoardCardProps {
workspace: AccessibleV2Workspace;
}

export function V2WorkspacesBoardCard({
// Memoized for the same reason as V2WorkspaceRow: board-wide filter changes
// must not re-render every card.
export const V2WorkspacesBoardCard = memo(function V2WorkspacesBoardCard({
workspace,
}: V2WorkspacesBoardCardProps) {
// Archived tombstones have no worktree or terminals left — no navigation
Expand All @@ -27,7 +30,7 @@ export function V2WorkspacesBoardCard({
)}
</V2WorkspaceContextMenu>
);
}
});

function BoardCardBody({
workspace,
Expand Down
Loading
Loading