perf: eliminate per-iteration allocation in fillBufferSingleBitAllocated#378
Open
suyashkumar wants to merge 1 commit into
Open
perf: eliminate per-iteration allocation in fillBufferSingleBitAllocated#378suyashkumar wants to merge 1 commit into
suyashkumar wants to merge 1 commit into
Conversation
Move the rawData buffer allocation outside the loop so a single []byte is reused across all iterations instead of allocating once per 8-pixel group. For a 512×512 1-bit image this reduces allocs from 32,770 to 3 per call and improves throughput by ~1.6× (379µs → 233µs). Also adds BenchmarkFillBufferSingleBitAllocated to cover this path, which was previously untested by the existing benchmark suite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the rawData buffer allocation outside the loop so a single []byte is reused across all iterations instead of allocating once per 8-pixel group. For a 512×512 1-bit image this reduces allocs from 32,770 to 3 per call and improves throughput by ~1.6× (379µs → 233µs).
Also adds BenchmarkFillBufferSingleBitAllocated to cover this path.