Open
Conversation
🦋 Changeset detectedLatest commit: e3b6932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
I'm glad this is being worked on. It's been bugging me since release. const base = z.object({ /* some fields */})
const type1 = base.extend({
typeId: z.literal(1),
/* other fields */
})
const type2 = base.extend({
typeId: z.literal(2),
/* other fields */
})
const combined = z.discriminatedUnion('typeId',
[type1, type2]
)TS doesn't even accept literal values like
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current types are a bit weird to work with...since it's expecting something if you have a variable that can be
nullorundefinedit will yell at you (even tho it doesn't make sense sinceundefinedis technically an acceptable value).Furthermore the
(string | {})trick doesn't make sense here where the value can be anything (anumberfor example).There's still one issue that I wasn't fully able to solve yet: for
checkboxif you have abooleanvalue TS will complain becausebooleanis not assignable totrueandfalsewhich is what the type is expecting (actual strict values, not justboolean).Do you have any ideas on how to fix this?