Skip to content

fix: correctly block on earlier batches #17971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dummdidumm wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

fix: correctly block on earlier batches #17971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5695f5a
run batch.traverse without `previous` of prior batches, only render e…
dummdidumm Mar 19, 2026
3ab8601
blocker/reject/merge work
dummdidumm Mar 19, 2026
97939fc
bring over test from #17935
dummdidumm Mar 19, 2026
36a2d8b
more tests
dummdidumm Mar 19, 2026
bd0a8f8
fix
dummdidumm Mar 19, 2026
4b6a225
fix and more tests
dummdidumm Mar 20, 2026
d175cc4
fix
dummdidumm Mar 20, 2026
9cf140c
actually we don't need merging
dummdidumm Mar 20, 2026
1f03a8b
fork stuff
dummdidumm Mar 20, 2026
4de5e7c
Merge branch 'main' into async-blocking-and-merging
Rich-Harris Mar 21, 2026
1819765
feedback
dummdidumm Mar 22, 2026
c19916a
oops
dummdidumm Mar 22, 2026
298437a
feedback
dummdidumm Mar 22, 2026
e90c4a3
handle new effects with fork
dummdidumm Mar 23, 2026
2732690
replay async deriveds of other batches when fork commits (are we slow…
dummdidumm Mar 23, 2026
79e208d
fulfil on first successful promise to ensure later updated can correc…
dummdidumm Mar 23, 2026
61a2d30
gah, we need merging after all (if all async deriveds are obsolete th…
dummdidumm Mar 23, 2026
4eac6a4
guess this feature is too new
dummdidumm Mar 23, 2026
d62b7f7
reorder tests + one testing various permutations (currently failing)
dummdidumm Mar 24, 2026
9fdcfe1
oops
dummdidumm Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/svelte/src/internal/client/reactivity/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export function capture() {
// TODO we only need optional chaining here because `{#await ...}` blocks
// are anomalous. Once we retire them we can get rid of it
previous_batch?.activate();
previous_batch?.apply();
}

if (DEV) {
Expand Down
Loading
Loading