Open
Conversation
Owner
|
Hello Fernando, first of all let me highlight that I appreciate your effort in fixing the problem and creating a pull request. However, I'm hestitant to merge this request. I know that I also proposed this solution in issue #9 , but I should have made it more clear that I don't consider it to be so much of a clean solution. Instead it is more a workaround for testing the functionality. My prefered solution was to actually add a MoveIt! controller manager plugin (for the youBot), that is more or less a mixture of the functionality in your pull request and the gripper controller handle [1]. That was the first point in my comment on issue #9 . Best regards |
Author
|
Ok! I'll do it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a controller manager to use the gripper