Potential fix for code scanning alert no. 17: Uncontrolled data used in path expression#84
Draft
maxirmx wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 17: Uncontrolled data used in path expression#84maxirmx wants to merge 1 commit into
maxirmx wants to merge 1 commit into
Conversation
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/sw-consulting/media-pi.device/security/code-scanning/17
To fix this safely without changing core functionality (still allowing configurable subdirectories), validate that
playlistDestinationresolves under a fixed safe base directory before saving it. The best place is inHandleConfigurationUpdate(input validation boundary), and optionally enforce again at use sites for defense-in-depth.For the shown code, update
internal/agent/menu.gowherecleanDestinationis computed:/var/media-pi).base + path separator.cleanDestination) in config as before.This prevents traversal and arbitrary absolute path selection while preserving intended behavior of writing playlists into configurable folders under the application directory.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.