fix: OAS 3.1 schema generation for raw Object properties is controlled with explicit-object-schema flag#5112
Open
Mattias-Sehlstedt wants to merge 1 commit intoswagger-api:masterfrom
Conversation
| @Override | ||
| public Schema createProperty31() { | ||
| return explicitObjectType == null || explicitObjectType ? new JsonSchema().typesItem("object") : new JsonSchema(); | ||
| return Boolean.TRUE.equals(explicitObjectType) ? new JsonSchema().typesItem("object") : new JsonSchema(); |
Contributor
Author
There was a problem hiding this comment.
This is the main change where null is changed from true to false
Mattias-Sehlstedt
force-pushed
the
java-object-is-only-set-to-type-object-if-flag-is-true
branch
from
ea4f967 to
a693594
Compare
…d with explicit-object-schema flag
Mattias-Sehlstedt
force-pushed
the
java-object-is-only-set-to-type-object-if-flag-is-true
branch
from
a693594 to
8141257
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Reverts changes from #5034 and restores the default resolving behavior for an OAS 3.1 Java
Objectto an empty type rather than typeobject.Adds tests to highlight that such a resolving logic should be achieved by setting the
explicit-object-schemaflag to true.Fixes: #5111
Type of Change
Checklist
Screenshots / Additional Context